Removed hardcoded contract list from ERC-20 internal plugin

LedgerHQ · Jan 14, 2025 · 3da3968 · 3da3968
1 parent e472523
commit 3da3968
Showing 1 changed file with 6 additions and 72 deletions.
diff --git a/src_plugins/erc20/erc20_plugin.c b/src_plugins/erc20/erc20_plugin.c
@@ -7,8 +7,6 @@
 
 typedef enum { ERC20_TRANSFER = 0, ERC20_APPROVE } erc20Selector_t;
 
-typedef enum { TARGET_ADDRESS = 0, TARGET_CONTRACT } targetType_t;
-
 #define MAX_CONTRACT_NAME_LEN 15
 
 typedef struct erc20_parameters_t {
@@ -17,61 +15,9 @@ typedef struct erc20_parameters_t {
     uint8_t amount[INT256_LENGTH];
     char ticker[MAX_TICKER_LEN];
     uint8_t decimals;
-    uint8_t target;
     char contract_name[MAX_CONTRACT_NAME_LEN];
 } erc20_parameters_t;
 
-typedef struct contract_t {
-    char name[MAX_CONTRACT_NAME_LEN];
-    uint8_t address[ADDRESS_LENGTH];
-} contract_t;
-
-#define NUM_CONTRACTS 13
-const contract_t CONTRACTS[NUM_CONTRACTS] = {
-    // Compound
-    {"Compound DAI", {0x5d, 0x3a, 0x53, 0x6e, 0x4d, 0x6d, 0xbd, 0x61, 0x14, 0xcc,
-                      0x1e, 0xad, 0x35, 0x77, 0x7b, 0xab, 0x94, 0x8e, 0x36, 0x43}},
-    {"Compound ETH", {0x4d, 0xdc, 0x2d, 0x19, 0x39, 0x48, 0x92, 0x6d, 0x02, 0xf9,
-                      0xb1, 0xfe, 0x9e, 0x1d, 0xaa, 0x07, 0x18, 0x27, 0x0e, 0xd5}},
-    {"Compound USDC", {0x39, 0xaa, 0x39, 0xc0, 0x21, 0xdf, 0xba, 0xe8, 0xfa, 0xc5,
-                       0x45, 0x93, 0x66, 0x93, 0xac, 0x91, 0x7d, 0x5e, 0x75, 0x63}},
-    {"Compound ZRX", {0xb3, 0x31, 0x9f, 0x5d, 0x18, 0xbc, 0x0d, 0x84, 0xdd, 0x1b,
-                      0x48, 0x25, 0xdc, 0xde, 0x5d, 0x5f, 0x72, 0x66, 0xd4, 0x07}},
-    {"Compound USDT", {0xf6, 0x50, 0xc3, 0xd8, 0x8d, 0x12, 0xdb, 0x85, 0x5b, 0x8b,
-                       0xf7, 0xd1, 0x1b, 0xe6, 0xc5, 0x5a, 0x4e, 0x07, 0xdc, 0xc9}},
-    {"Compound WBTC", {0xc1, 0x1b, 0x12, 0x68, 0xc1, 0xa3, 0x84, 0xe5, 0x5c, 0x48,
-                       0xc2, 0x39, 0x1d, 0x8d, 0x48, 0x02, 0x64, 0xa3, 0xa7, 0xf4}},
-    {"Compound BAT", {0x6c, 0x8c, 0x6b, 0x02, 0xe7, 0xb2, 0xbe, 0x14, 0xd4, 0xfa,
-                      0x60, 0x22, 0xdf, 0xd6, 0xd7, 0x59, 0x21, 0xd9, 0x0e, 0x4e}},
-    {"Compound REP", {0x15, 0x80, 0x79, 0xee, 0x67, 0xfc, 0xe2, 0xf5, 0x84, 0x72,
-                      0xa9, 0x65, 0x84, 0xa7, 0x3c, 0x7a, 0xb9, 0xac, 0x95, 0xc1}},
-    {"Compound SAI", {0xf5, 0xdc, 0xe5, 0x72, 0x82, 0xa5, 0x84, 0xd2, 0x74, 0x6f,
-                      0xaf, 0x15, 0x93, 0xd3, 0x12, 0x1f, 0xca, 0xc4, 0x44, 0xdc}},
-    {"Compound UNI", {0x35, 0xa1, 0x80, 0x00, 0x23, 0x0d, 0xa7, 0x75, 0xca, 0xc2,
-                      0x48, 0x73, 0xd0, 0x0f, 0xf8, 0x5b, 0xcc, 0xde, 0xd5, 0x50}},
-    // Paraswap
-    {"Paraswap", {0x1b, 0xd4, 0x35, 0xf3, 0xc0, 0x54, 0xb6, 0xe9, 0x01, 0xb7,
-                  0xb1, 0x08, 0xa0, 0xab, 0x76, 0x17, 0xc8, 0x08, 0x67, 0x7b}},
-
-    // stETH
-    {"Lido", {0x7f, 0x39, 0xc5, 0x81, 0xf5, 0x95, 0xb5, 0x3c, 0x5c, 0xb1,
-              0x9b, 0xd0, 0xb3, 0xf8, 0xda, 0x6c, 0x93, 0x5e, 0x2c, 0xa0}},
-
-    // wstETH
-    {"Wrapped stETH", {0xae, 0x7a, 0xb9, 0x65, 0x20, 0xde, 0x3a, 0x18, 0xe5, 0xe1,
-                       0x11, 0xb5, 0xea, 0xab, 0x09, 0x53, 0x12, 0xd7, 0xfe, 0x84}}};
-
-bool check_contract(erc20_parameters_t *context) {
-    for (size_t i = 0; i < NUM_CONTRACTS; i++) {
-        const contract_t *contract = (const contract_t *) PIC(&CONTRACTS[i]);
-        if (memcmp(contract->address, context->destinationAddress, ADDRESS_LENGTH) == 0) {
-            strlcpy(context->contract_name, contract->name, sizeof(context->contract_name));
-            return true;
-        }
-    }
-    return false;
-}
-
 void erc20_plugin_call(int message, void *parameters) {
     switch (message) {
         case ETH_PLUGIN_INIT_CONTRACT: {
@@ -148,14 +94,8 @@ void erc20_plugin_call(int message, void *parameters) {
                    (msg->item1 != NULL),
                    (msg->item2 != NULL));
             if (msg->item1 != NULL) {
-                context->target = TARGET_ADDRESS;
                 strlcpy(context->ticker, msg->item1->token.ticker, MAX_TICKER_LEN);
                 context->decimals = msg->item1->token.decimals;
-                if (context->selectorIndex == ERC20_APPROVE) {
-                    if (check_contract(context)) {
-                        context->target = TARGET_CONTRACT;
-                    }
-                }
                 msg->result = ETH_PLUGIN_RESULT_OK;
             } else {
                 msg->result = ETH_PLUGIN_RESULT_FALLBACK;
@@ -196,19 +136,13 @@ void erc20_plugin_call(int message, void *parameters) {
                     msg->result = ETH_PLUGIN_RESULT_OK;
                     break;
                 case 1:
-                    if (context->target >= TARGET_CONTRACT) {
-                        strlcpy(msg->title, "Contract", msg->titleLength);
-                        strlcpy(msg->msg, context->contract_name, msg->msgLength);
-                    } else {
-                        strlcpy(msg->title, "Approve to", msg->titleLength);
-                        if (!getEthDisplayableAddress(context->destinationAddress,
-                                                      msg->msg,
-                                                      msg->msgLength,
-                                                      chainConfig->chainId)) {
-                            msg->result = ETH_PLUGIN_RESULT_ERROR;
-                        }
+                    strlcpy(msg->title, "Approve to", msg->titleLength);
+                    if (!getEthDisplayableAddress(context->destinationAddress,
+                                                  msg->msg,
+                                                  msg->msgLength,
+                                                  chainConfig->chainId)) {
+                        msg->result = ETH_PLUGIN_RESULT_ERROR;
                     }
-
                     msg->result = ETH_PLUGIN_RESULT_OK;
                     break;
                 default: