More state refactoring #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbrower95
commented
Dec 9, 2024
src/utils/ZEnvHelpers.sol
Outdated
| @@ -212,4 +231,42 @@ library ZEnvHelpers { | |||
| string memory envvar = string.concat(ENV_PREFIX, key); | |||
| return vm.envBool(envvar); | |||
| } | |||
|
|
|||
| function __markDirty(State storage s, string memory key) internal { | |||
There was a problem hiding this comment.
__markDirty is only internal vs. private because the state updating logic is still in ZeusScript for some reason
There was a problem hiding this comment.
maybe we'll move that too in the future
jbrower95
force-pushed
the
jb/fix-state
branch
from
3fc2c88 to
90ae48b
Compare
jbrower95
force-pushed
the
jb/fix-state
branch
from
90ae48b to
3fc2c88
Compare
jbrower95
force-pushed
the
jb/fix-state
branch
from
3fc2c88 to
6a4f71b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.