Cleanup/roots of unities setup functions #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Samuel Laferriere <[email protected]>
Co-authored-by: Samuel Laferriere <[email protected]>
Co-authored-by: Samuel Laferriere <[email protected]>
Co-authored-by: Samuel Laferriere <[email protected]>
Co-authored-by: Samuel Laferriere <[email protected]>
samlaf
reviewed
Jan 12, 2025
anupsv
commented
Jan 14, 2025
| /// let max_size = 64; | ||
| /// let bytes = to_byte_array(&elements, max_size); | ||
| /// assert_eq!(bytes.len(), 64); | ||
| /// // bytes will contain up to max_size bytes from the encoded elements |
There was a problem hiding this comment.
Removed this cause its the wrong example. Also as it's not a public function doctests can't work with it, so I just kept the documentation part since it's useful.
samlaf
approved these changes
Jan 14, 2025
Yep, fixed both. Apparently vscode's refactor symbol needs more work on detection. |
anupsv
added a commit
that referenced
this pull request
Jan 15, 2025
* adding bare changes for batch verification * adding some comments * adding more comments * moving back to sha2 * removing a test which is no longer needed. Removing methods no longer needed * updates to method visibility, updating tests * fmt fixes * clean up * cleanup, optimization, inline docs * removing unwanted const * more docs and cleanup * formatting * removing unwanted comments * cargo fmt and clippy * adding test for point at infinity * cleaner errors, cleanup * adding another test case * removing unwanted errors * adding fixes per comments * adding 4844 spec references * comment fixes * formatting, adding index out of bound check, removing print statement * removing unwanted test, adding test for evaluate_polynomial_in_evaluation_form * moving test to bottom section * Update src/polynomial.rs Co-authored-by: Samuel Laferriere <[email protected]> * Update src/kzg.rs Co-authored-by: Samuel Laferriere <[email protected]> * Update src/kzg.rs Co-authored-by: Samuel Laferriere <[email protected]> * Update src/kzg.rs Co-authored-by: Samuel Laferriere <[email protected]> * Update src/helpers.rs Co-authored-by: Samuel Laferriere <[email protected]> * updating deps, and toolchain to 1.84 * removing errors test, no longer useful * adding to_byte_array arg explanation * fmt fixes * fmt and clippy fixes * fixing function names and fmt * clippy fixes * removing unwanted setup functions * removing vars from struct * fixing function name and comments * fixing naming for tests * fixing naming in benches * formatting * removing is_zero --------- Co-authored-by: anupsv <[email protected]> Co-authored-by: Samuel Laferriere
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing 2 functions
Removing unwanted struct fields
Changing tests and bench functions
Addresses: #28