chore(eigenda): Bump eigenda-proxy to latest v1.6.0 #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samlaf
reviewed
Dec 3, 2024
Comment on lines
+23
to
+26
| if [ $? -ne 0 ]; then | ||
| echo "==== Failed to start eigenda-proxy container ====" | ||
| exit 1 | ||
| fi |
There was a problem hiding this comment.
nit: this will catch if docker didn't manager to start the process, but won't catch if the process is started but crashed on startup.
Comment on lines
-130
to
-131
| if resp.StatusCode == http.StatusServiceUnavailable { | ||
| return nil, SvcUnavailableErr |
There was a problem hiding this comment.
Did you really mean to remove this? Is ErrSvcUnavailable returned somewhere else?
There was a problem hiding this comment.
ahh incredible catch 🙏🏻
| return nil, fmt.Errorf("received unexpected response code: %d", resp.StatusCode) | ||
| b, err := io.ReadAll(resp.Body) | ||
| if err != nil { | ||
| return nil, err |
There was a problem hiding this comment.
nit: wrap err with resp.StatusCode
litt3
approved these changes
Dec 3, 2024
samlaf
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes