Tx manager #61
Merged
Tx manager #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add fee calculation to TxManager
|
@dralves this PR is ready for a new review |
dralves
approved these changes
Aug 12, 2024
|
Merge conflicts |
dralves
approved these changes
Aug 13, 2024
| /// Send is used to send a transaction to the Ethereum node. It takes an unsigned/signed transaction | ||
| /// and then sends it to the Ethereum node. | ||
| /// If you pass in a signed transaction it will ignore the signature | ||
| /// and resign the transaction after adding the nonce and gas limit. |
There was a problem hiding this comment.
Suggested change
| /// and resign the transaction after adding the nonce and gas limit. | |
| /// and re-sign the transaction after adding the nonce and gas limit. |
| } | ||
|
|
||
| /// Send is used to send a transaction to the Ethereum node. It takes an unsigned/signed transaction | ||
| /// and then sends it to the Ethereum node. |
There was a problem hiding this comment.
Suggested change
| /// and then sends it to the Ethereum node. | |
| /// ,sends it to the Ethereum node and waits for the receipt. |
|
Comments addressed @dralves @supernovahs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transaction manager, includes the gas estimation of the transaction.