Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove existing bindings when generating new ones #242

Merged
merged 1 commit into from
Jan 21, 2025
Merged

chore: remove existing bindings when generating new ones #242

merged 1 commit into from
Jan 21, 2025

Conversation

ricomateo
Copy link
Contributor

@ricomateo ricomateo commented Jan 20, 2025 •
edited
Loading

What Changed?

This PR changes the make bindings target to remove the existing bindings before generating the new ones.
This is important since it removes potentially unused bindings.

Reviewer Checklist

  • New features are tested and documented
  • PR has one of the changelog-X labels (if applies)
  • Code deprecates any old functionality before removing it

@ricomateo ricomateo marked this pull request as ready for review January 21, 2025 13:11
@pablodeymo pablodeymo merged commit d479799 into main Jan 21, 2025
5 checks passed
@pablodeymo pablodeymo deleted the remove-old-bindings-in-makefile-target branch January 21, 2025 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablodeymo pablodeymo pablodeymo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ricomateo @pablodeymo