Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Update sdk to new contract layout with slashing feature branch #415

Draft
wants to merge 14 commits into
base: dev
Choose a base branch
from

Conversation

afkbyte
Copy link
Contributor

@afkbyte afkbyte commented Dec 23, 2024

What Changed?

Reviewer Checklist

  • Code is well-documented
  • Code adheres to Go naming conventions
  • Code deprecates any old functionality before removing it

@afkbyte afkbyte requested a review from pablodeymo December 23, 2024 19:10
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this file should be removed from the PR.

if err != nil {
return nil, utils.WrapError("Failed to get AllocationManager address", err)
}

}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, we could add the same idea of the check as in elcontracts:

if isZeroAddress(cfg.AllocationManagerAddress) {
...

if we don't get the address of the allocation Manager, we should ignore it while creating the return of the function.

@pablodeymo
Copy link
Contributor

It should be good to make this compatible with previous version of AVSs contract code.
To do so, we can ignore missing allocation manager addresses and allocation manager function in serviceManager.

@shrimalmadhur
Copy link
Collaborator

@afkbyte we have been working off this branch for core contracts and other slashing changes. I think we are duplicating some work here #342

@shrimalmadhur
Copy link
Collaborator

shrimalmadhur commented Dec 26, 2024

@afkbyte we have been working off this branch for core contracts and other slashing changes. I think we are duplicating some work here #342

The only thing my branch lacks is new middleware bindings and respective tests. I think we should fork out of my branch and then add those. Wdyt?

@haardikk21
Copy link

Hey folks - since the holesky contracts have been upgraded, this PR is blocking AVS testing on testnet as latest release of eigensdk-go attempts to call a slasher() view function on the delegation manager which no longer exists

It's the holidays so no pressure at all, but just out of curiosity do you have an ETA for this PR (or #342) to be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants