-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT MERGE] Update sdk to new contract layout with slashing feature branch #415
base: dev
Are you sure you want to change the base?
Conversation
…manager address references and update eigenpod bindings
…bash script to do so
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this file should be removed from the PR.
if err != nil { | ||
return nil, utils.WrapError("Failed to get AllocationManager address", err) | ||
} | ||
|
||
} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here, we could add the same idea of the check as in elcontracts:
if isZeroAddress(cfg.AllocationManagerAddress) {
...
if we don't get the address of the allocation Manager, we should ignore it while creating the return of the function.
It should be good to make this compatible with previous version of AVSs contract code. |
Hey folks - since the holesky contracts have been upgraded, this PR is blocking AVS testing on testnet as latest release of eigensdk-go attempts to call a It's the holidays so no pressure at all, but just out of curiosity do you have an ETA for this PR (or #342) to be merged? |
What Changed?
Reviewer Checklist