Avoid panics #389
Open
Avoid panics #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablodeymo
changed the title
afkbyte
reviewed
Jan 15, 2025
| metrics := NewMetrics(reg, "example", logger) | ||
| return client, NewGeometricTxnManager(client, wallet, logger, metrics, GeometricTxnManagerParams{}), nil | ||
| } | ||
|
|
||
| func ExampleGeometricTxManager() { | ||
| anvilC, err := testutils.StartAnvilContainer("") | ||
| if err != nil { |
There was a problem hiding this comment.
I think we should also avoid the use of panics in the examples as well
afkbyte
reviewed
Jan 15, 2025
| @@ -76,11 +76,16 @@ func (ar *AvsRegistryServiceChainCaller) GetOperatorsAvsStateAtBlock( | |||
| } | |||
| numquorums := len(quorumNumbers) | |||
| if len(operatorsStakesInQuorums) != numquorums { | |||
| ar.logger.Fatal( | |||
| ar.logger.Error( | |||
There was a problem hiding this comment.
I would add the values of operatorsStakesInQuorums and numquorums in this log for debugging
afkbyte
reviewed
Jan 15, 2025
| @@ -128,8 +123,9 @@ func (ops *OperatorsInfoServiceInMemory) startServiceInGoroutine( | |||
| queryC <-chan query, | |||
| wg *sync.WaitGroup, | |||
| opts Opts, | |||
| ) { | |||
| go func() { | |||
| ) chan<- error { | |||
There was a problem hiding this comment.
I think it would be more readable/and simplify error handling if we replaced the error channel with an error group here
There was a problem hiding this comment.
Great idea! I added it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
What Changed?
The functions
BuildReadClients,BuildAll,NewZapLoggerByConfig, andAvsRegistryServiceChainCaller.GetOperatorsAvsStateAtBlockreturn errors instead of panicking.The
OperatorsInfoServiceInMemoryno longer panics (errors are only logged).Reviewer Checklist