signer module removed, since it's deprecated #366
Conversation
|
There's a READMe.md file inside the signerv2 folder. We should add a small description there on how it works and add a "How to upgrade from deprecated signer" section as well |
Added |
| Signers instantiated from this module is required to create some SDK transaction managers (see [`NewPrivateKeyWallet`](../chainio/clients/wallet/privatekey_wallet.go) and [`NewSimpleTxManager`](../chainio/txmgr/simple.go)/[`NewGeometricTxnManager`](../chainio/txmgr/geometric/geometric.go)). | ||
|
|
||
| ## Features |
There was a problem hiding this comment.
I think it would be beneficial to include examples for each of the different signing mechanisms, would provide better context for devs wanting to use our signer!
There was a problem hiding this comment.
Sure! We can tackle that in another PR. I created #440 to track it.
| ### Using SignerFromConfig | ||
|
|
||
| SignerV2 introduces `SignerFromConfig` |
There was a problem hiding this comment.
Might be nice to show and break down what the config contains here in the docs
There was a problem hiding this comment.
I added the suggestion to #440
Fixes # .
What Changed?
Signer module was revamped in #403. Users should move to signerv2, in case they weren't doing so. Instructions on how to move are in the module's readme.
Reviewer Checklist