Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change the way exec.Command is called to sanitize parameters #356

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Change the way exec.Command is called to sanitize parameters #356

merged 2 commits into from
Oct 2, 2024

Conversation

pablodeymo
Copy link
Contributor

Fixes # .

What Changed?

Reviewer Checklist

  • Code is well-documented
  • Code adheres to Go naming conventions
  • Code deprecates any old functionality before removing it

bxue-l2
bxue-l2 previously approved these changes Sep 27, 2024
View reviewed changes
@bxue-l2 bxue-l2 dismissed their stale review September 27, 2024 00:59

hit a wrong button

@pablodeymo pablodeymo requested a review from afkbyte October 2, 2024 15:40
@shrimalmadhur shrimalmadhur added this pull request to the merge queue Oct 2, 2024
Merged via the queue into dev with commit c666771 Oct 2, 2024
4 checks passed
@shrimalmadhur shrimalmadhur deleted the avoid_tainted_parameters branch October 2, 2024 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanbono juanbono juanbono left review comments

@shrimalmadhur shrimalmadhur shrimalmadhur approved these changes

@bxue-l2 bxue-l2 bxue-l2 left review comments

@afkbyte afkbyte Awaiting requested review from afkbyte

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@pablodeymo @shrimalmadhur @juanbono @bxue-l2