Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change rand library for a a cryptographically secure random number generator one #349

Merged
merged 3 commits into from
Oct 2, 2024
Merged

Change rand library for a a cryptographically secure random number generator one #349

merged 3 commits into from
Oct 2, 2024

Conversation

pablodeymo
Copy link
Contributor

@pablodeymo pablodeymo commented Sep 24, 2024 •
edited
Loading

What Changed?

The library math/rand is not a cryptographically secure random number generator.
This PR changes the use of the library in favor of crypto/rand.

Additionally, err value was not properly checked in generateECDSAKeys and generateBlsKeys functions

Reviewer Checklist

  • Code is well-documented
  • Code adheres to Go naming conventions
  • Code deprecates any old functionality before removing it

@pablodeymo pablodeymo marked this pull request as draft September 24, 2024 20:39
@pablodeymo pablodeymo marked this pull request as ready for review September 24, 2024 21:06
juanbono
juanbono approved these changes Sep 25, 2024
View reviewed changes
Copy link
Contributor

@juanbono juanbono left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@samlaf samlaf added this pull request to the merge queue Sep 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Sep 27, 2024
@samlaf samlaf added this pull request to the merge queue Sep 27, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to no response for status checks Sep 27, 2024
@pablodeymo pablodeymo requested a review from afkbyte October 2, 2024 15:41
@shrimalmadhur shrimalmadhur added this pull request to the merge queue Oct 2, 2024
@shrimalmadhur shrimalmadhur removed this pull request from the merge queue due to the queue being cleared Oct 2, 2024
@shrimalmadhur shrimalmadhur added this pull request to the merge queue Oct 2, 2024
Merged via the queue into dev with commit 27cb994 Oct 2, 2024
4 checks passed
@shrimalmadhur shrimalmadhur deleted the change_rand_library branch October 2, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juanbono juanbono juanbono approved these changes

@shrimalmadhur shrimalmadhur shrimalmadhur approved these changes

@afkbyte afkbyte Awaiting requested review from afkbyte

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pablodeymo @shrimalmadhur @juanbono