Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add rewards methods for claim generation #287

Merged
merged 3 commits into from
Jul 2, 2024
Merged

add rewards methods for claim generation #287

merged 3 commits into from
Jul 2, 2024

Conversation

shrimalmadhur
Copy link
Collaborator

Fixes # .

What Changed?

  • Add Distribution Length Method
  • Add Process claim method

Reviewer Checklist

  • Code is well-documented
  • Code adheres to Go naming conventions
  • Code deprecates any old functionality before removing it

@shrimalmadhur shrimalmadhur requested a review from samlaf July 2, 2024 22:26
samlaf
samlaf previously approved these changes Jul 2, 2024
View reviewed changes
chainio/clients/elcontracts/writer.go Outdated

noSendTxOpts, err := w.txMgr.GetNoSendTxOpts()
if err != nil {
return nil, err
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrap error

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

9ae2d87

chainio/clients/elcontracts/writer.go Outdated

tx, err := w.rewardsCoordinator.ProcessClaim(noSendTxOpts, claim, earnerAddress)
if err != nil {
return nil, err
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wrap error

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

9ae2d87

@shrimalmadhur shrimalmadhur requested a review from samlaf July 2, 2024 22:42
@samlaf samlaf merged commit e8dc050 into dev Jul 2, 2024
4 checks passed
@samlaf samlaf deleted the madhur/add-rewards-methods branch July 2, 2024 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samlaf samlaf samlaf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shrimalmadhur @samlaf