Add PR checks for broken links #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
teddyknox
requested review from
wesfloyd,
0xsennasempre,
joan-el and
QuinnLee
as code owners
teddyknox
requested review from
bpm6867,
cpdcpd,
cjlayr,
shrimalmadhur and
tinahaibodi
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
shrimalmadhur
previously approved these changes
Feb 2, 2024
|
you think it's useful to have a local make command for checking this too? like someone making changes can check or - eventually can be a check in precommit? |
teddyknox
force-pushed
the
broken-links-test
branch
from
4e2ed43 to
cc9602b
Compare
|
@shrimalmadhur good idea. Added. Could you approve again? |
teddyknox
force-pushed
the
broken-links-test
branch
from
cc9602b to
511cd8b
Compare
teddyknox
force-pushed
the
broken-links-test
branch
from
511cd8b to
4d9df51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Should fail any PR that breaks a link that used to work.
The check fails in this PR because the script used in the "base" commit does not exist yet, so the check must be overriden.