Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: return attestation err result to dispatcher #1011

Merged

Conversation

ian-shim
Copy link
Contributor

Why are these changes needed?

Makes sure sigChan receives exactly len(operators) results.
Expand logging.

Checks

  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • I've checked the new test coverage and the coverage percentage didn't drop.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@ian-shim ian-shim force-pushed the dispatcher-return-err-to-sig-chan branch from e1b1b0f to 46955b1 Compare December 17, 2024 00:22
@ian-shim ian-shim force-pushed the dispatcher-return-err-to-sig-chan branch 6 times, most recently from ebde2d5 to 39e1552 Compare December 17, 2024 01:27
@ian-shim ian-shim force-pushed the dispatcher-return-err-to-sig-chan branch from 39e1552 to d394332 Compare December 17, 2024 01:42
@ian-shim ian-shim marked this pull request as ready for review December 17, 2024 01:57
@ian-shim ian-shim merged commit fc5dff1 into Layr-Labs:master Dec 17, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants