fix small bugs in deploy flow #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samlaf
commented
Aug 31, 2024
| @@ -86,7 +86,7 @@ services: | |||
| service: proxy | |||
|
|
|||
| nitro: | |||
| image: ghcr.io/layr-labs/nitro-eigenda:8b4f4ce | |||
| image: ghcr.io/layr-labs/nitro-eigenda:8b4f4ce@sha256:13de1fe786200289d52a68d2b8451c7cd55972d784dbc21dd9181c161ea24996 | |||
There was a problem hiding this comment.
pinning sha version is needed to let docker download the image on mac given we only publish an x86 image
samlaf
commented
Aug 31, 2024
| @@ -22,10 +22,13 @@ | |||
| "ts-node": "^10.9.1", | |||
| "typescript": "^5.1.3" | |||
| }, | |||
| "engines": { | |||
| "yarn": ">=1.22.0 < 2.0.0" | |||
There was a problem hiding this comment.
pinning yarn version to something arbitrary. Feel free to change
samlaf
commented
Aug 31, 2024
| @@ -2,7 +2,7 @@ | |||
| "name": "orbit-setup-script", | |||
| "dependencies": { | |||
| "@arbitrum/nitro-contracts": "^1.1.1", | |||
| "@arbitrum/orbit-sdk": "^0.8.0", | |||
| "@arbitrum/orbit-sdk": "^0.9.0", | |||
There was a problem hiding this comment.
had to update this to 0.9.0 because the 0.8.0 version didn't have holesky in its chain config for some reason (even though I checked in their repo and its there in the tagged branch...)
Bowen was getting the same error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.