Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: eigenda-nitro nodeConfig and ChainConfig types #1

Merged
merged 1 commit into from
Aug 20, 2024
Merged

feat: eigenda-nitro nodeConfig and ChainConfig types #1

merged 1 commit into from
Aug 20, 2024

Conversation

hopeyen
Copy link
Collaborator

@hopeyen hopeyen commented Aug 15, 2024

  • rollup creation parameters
  • updated rollup creator ABI
    • did not update bridge creator ABI
  • updated multiple batchPosters allowed for deployment parameter
  • added default deployment parameter for eigenDARollupManager is zero since the contract will create a dummy if zero address
  • added default deployment parameter for batchPosterManager is the signer account itself if not set
  • updated corresponding tests and generation files

epociask
epociask approved these changes Aug 20, 2024
View reviewed changes
Copy link
Collaborator

@epociask epociask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hopeyen hopeyen merged commit fe08a1d into main Aug 20, 2024
1 of 5 checks passed
@hopeyen hopeyen deleted the hope/eigenda-integration branch August 20, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@epociask epociask epociask approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hopeyen @epociask