Add infinite scroll option to homepage #4945
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Related to LawnchairLauncher#4943 Add infinite scroll option to the homepage. * **LawnchairLauncher.kt** - Observe the `infiniteScroll` preference and update the launcher accordingly. * **HomeScreenPreferences.kt** - Add a switch to enable/disable infinite scroll in the layout preference group. * **HomeScreenGridPreferences.kt** - Add a switch to enable/disable infinite scroll in the layout preference group.
validcube
reviewed
Oct 29, 2024
Comment on lines
+132
to
+133
| label = stringResource(id = R.string.infinite_scroll_label), | ||
| description = stringResource(id = R.string.infinite_scroll_description), |
There was a problem hiding this comment.
The string for infinite scroll appeared to be missing.
Comment on lines
+84
to
+86
| adapter = prefs.infiniteScroll.getAdapter(), | ||
| label = stringResource(id = R.string.infinite_scroll_label), | ||
| description = stringResource(id = R.string.infinite_scroll_description), |
There was a problem hiding this comment.
The string for infinite scroll appeared to be missing
Comment on lines
+199
to
+203
| // Observe the infiniteScroll preference and update the launcher accordingly | ||
| prefs.infiniteScroll.subscribeChanges(this) { infiniteScrollEnabled -> | ||
| // Add logic to handle infinite scroll based on the new preference | ||
| // For example, update the workspace or other relevant components | ||
| } |
There was a problem hiding this comment.
The code seems incomplete, at the moment(?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #4943
Add infinite scroll option to the homepage.
infiniteScrollpreference and update the launcher accordingly.