Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Issue #741] Add fsGroup for runtime pod #743

Merged
merged 1 commit into from
Dec 11, 2023
Merged

[Issue #741] Add fsGroup for runtime pod #743

merged 1 commit into from
Dec 11, 2023

Conversation

Dobosz
Copy link
Contributor

@Dobosz Dobosz commented Dec 11, 2023

No description provided.

@eolivelli
Copy link
Member

Thank you @Dobosz for sharing your solution.

Can you please fill in this form ?
https://cla.datastax.com
We need that in order commit your patch

nicoloboschi
nicoloboschi approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@nicoloboschi nicoloboschi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
please fill the form

@Dobosz
Copy link
Contributor Author

Dobosz commented Dec 11, 2023

Done

eolivelli
eolivelli approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thank you very much

@eolivelli eolivelli merged commit 2cd631c into LangStream:main Dec 11, 2023
10 checks passed
Dobosz added a commit to Dobosz/langstream that referenced this pull request Dec 13, 2023
@Dobosz
Revert "[Issue LangStream#741] Add fsGroup for runtime pod (LangStrea…
48235bc 
…m#743)"

This reverts commit 2cd631c.
Dobosz added a commit to Dobosz/langstream that referenced this pull request Dec 14, 2023
@Dobosz
Revert "[Issue LangStream#741] Add fsGroup for runtime pod (LangStrea…
4abf702 
…m#743)"

This reverts commit 2cd631c.
nicoloboschi pushed a commit that referenced this pull request Dec 14, 2023
@Dobosz
Issue 741 fix (#748)
f9b2d66 
* Revert "[Issue #741] Add fsGroup for runtime pod (#743)"

This reverts commit 2cd631c.

* [Issue #741] Fixes previous commit. fsGroup will now be assign to Agent STS and not App
benfrank241 pushed a commit to vectorize-io/langstream that referenced this pull request May 2, 2024
@Dobosz
[Issue LangStream#741] Add fsGroup for runtime pod (LangStream#743)
c80f4a9
benfrank241 pushed a commit to vectorize-io/langstream that referenced this pull request May 2, 2024
@Dobosz
Issue 741 fix (LangStream#748)
0eb2b64 
* Revert "[Issue LangStream#741] Add fsGroup for runtime pod (LangStream#743)"

This reverts commit 2cd631c.

* [Issue LangStream#741] Fixes previous commit. fsGroup will now be assign to Agent STS and not App
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicoloboschi nicoloboschi nicoloboschi approved these changes

@eolivelli eolivelli eolivelli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dobosz @eolivelli @nicoloboschi