[docker] Do not close classloaders, to prevent spammy ClassNotFoundExceptions #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoloboschi
requested changes
Oct 27, 2023
| Boolean.parseBoolean(System.getProperty("langstream.nar.closeClassloaders", "true")); | ||
|
|
||
| static { | ||
| log.info("langstream.nar.close-classloaders = {}", CLOSE_CLASSLOADERS); |
There was a problem hiding this comment.
please align to the system property name
nicoloboschi
approved these changes
Oct 27, 2023
eolivelli
force-pushed
the
imp/docker-not-close-classloaders
branch
from
2c71528 to
8f67bf1
Compare
benfrank241
pushed a commit
to vectorize-io/langstream
that referenced
this pull request
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the docker container is existing, usually due to an error in the configuration, we close the classloaders and this triggers a lot of spammy ClassNotFound errors that are misleading, because users think that there is a bug somewhere in LangStream.
The trick here is not not close them: the JMV is existing, there is no risk of leaking resources.
Also the tmp directory of the container is ephemeral: we are not leaving dangling temporary files