-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New http-request agent #537
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would make the query string parameters configurable, otherwise you have to provide a way to perform escaping.
Also I would make the url a constant in the first iteration, this way we prevent malicious usage, like calling URLs forged by a chatbot user
...stream-agent-http-request/src/main/java/ai/langstream/agents/queryhttp/HttpRequestAgent.java
Show resolved
Hide resolved
f6baebc
to
8ea3a05
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
It can be interesting to look at what features LangChain loaders provide when we create these Sources. |
http-request
agentExample with authentication