Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Iteration on the initial Course Syllabus #127

Merged
merged 9 commits into from
Sep 29, 2018

Conversation

drphilmarshall
Copy link
Contributor

@drphilmarshall drphilmarshall commented Sep 27, 2018

Not yet ready for review! But here's where I'm addressing my own review comments in PR #125:

  • Try splitting session 1 in two, to Basics followed by Getting Started
  • Add links to missing resources (esp DIA)
  • Remove projects and start issues instead - and then link issues back to syllabus.

I'll add more to-do's to the list above as I go, and then request a review from Alex when I'm done.

@drphilmarshall
Copy link
Contributor Author

OK @kadrlica I worked my way through sessions 1-5, adding links to a few more resources, doing some moving around of topics, and so on. I started two new project opportunity issues based on the gaps in the syllabus, #129 (Visualization: RGB cutouts) and #131 (Source detection: Explain everything). See what you think - I'm hoping this might be enough to get us started on Friday, when we could carry on and make some more issues, perhaps with the help of anyone looking for a new project.

Copy link
Contributor

@kadrlica kadrlica left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! The consistent formatting breaks down after Session 5, but I think that's ok. I think it's definitely ok for Friday, and we can continue to work on this an flesh it out.

Syllabus.md Outdated
@@ -192,7 +205,7 @@ We will explore LSST data visualization in a bit more detail. This session will
+ [Source measurement tutorial](https://pipelines.lsst.io/getting-started/photometry.html)
+ [Kron.ipynb](https://github.com/RobertLuptonTheGood/notebooks/blob/2eeee8b9fe35077387485e488c965f1ea3d39418/Demos/Kron.ipynb)

<a name="astrometry"></a>(9) Astrometric calibration
<a name="astrometry"></a>10. Astrometric calibration
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both the Source/Object measurement and Astrometric calibration are labeled section "10".

@kadrlica
Copy link
Contributor

@drphilmarshall I'm not sure how to do the joint merge of this PR with #125. What are best practices?

@drphilmarshall
Copy link
Contributor Author

Thanks @kadrlica ! I fixed the numbering, and completed the job of removing the projects to the issue list. I'll merge this PR, since its approved and I'm the owner; then I'll approve your PR for you to tweak and merge.

@drphilmarshall drphilmarshall merged commit e51ed48 into syllabus Sep 29, 2018
@drphilmarshall drphilmarshall deleted the syllabus-drphilmarshall branch September 29, 2018 19:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants