156 switch nose to pytest #157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 23, 2024 23:39
Closed
Pull Request Test Coverage Report for Build 10560951331Details
💛 - Coveralls |
timj
reviewed
Aug 23, 2024
setup.cfg
Outdated
| @@ -1,5 +1,6 @@ | |||
| [tool:pytest] | |||
| exclude=test_(extractor_ctio_planetary_nebula|astrometry|mcmc|multispectra) | |||
| # exclude=test_(extractor_ctio_planetary_nebula|astrometry|mcmc|multispectra) | |||
| addopts = --ignore=tests/test_astrometry.py --ignore=tests/test_mcmc.py --ignore=tests/test_extractor_ctio_planetary_nebula.py | |||
There was a problem hiding this comment.
Why are you ignoring broken tests rather than deleting them (or renaming them so pytest doesn't find them)? It looks like we mark test_astrometry.py as broken in our branch and skip it.
There was a problem hiding this comment.
Because the test work fine on my laptop but I don't understand why in the github workflow it fails. I still hope to find a solution one day so I don't delete the file...
added 2 commits
August 24, 2024 00:12
|
I have no more changes to bring to the code. Ready for review @timj |
timj
approved these changes
Aug 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.