-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dynamic versioning #1209
Fix dynamic versioning #1209
Changes from 19 commits
0bab475
5e775bd
ae0272f
5f294b6
2bdf45d
49a642a
81a5925
113574a
9b968a4
e6bd8dc
ddde046
ce9f2ce
6f45423
3d5f742
6858995
ebd8b79
6d6da0c
523cdca
0e0acb8
ac642f2
f4d4114
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
cmake_minimum_required(VERSION 3.2) | ||
cmake_minimum_required(VERSION 3.5) | ||
if (NOT CMAKE_BUILD_TYPE) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I am not sure why, but I wasn't able to fix dynamic versioning without this requirement. |
||
message(STATUS "No build type selected, default to Release") | ||
set(CMAKE_BUILD_TYPE Release CACHE STRING "Choose the type of build." FORCE) | ||
|
@@ -8,7 +8,7 @@ MESSAGE( STATUS "CMAKE_BUILD_TYPE: " ${CMAKE_BUILD_TYPE} ) | |
# Adding customized cmake module | ||
list(APPEND CMAKE_MODULE_PATH "${CMAKE_SOURCE_DIR}/cmake/Modules/") | ||
|
||
project(ccl VERSION 3.1) | ||
project(ccl VERSION 3.1.2) | ||
|
||
# Uncomment to get detailed build outputs | ||
# set( CMAKE_VERBOSE_MAKEFILE on ) | ||
|
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -186,7 +186,7 @@ def number_counts(self, cosmo, *, selection, | |
mint[i] = self._integrator( | ||
dVda[i] * self._mf[..., :] * _selm[..., :], | ||
self._lmass | ||
) | ||
).squeeze() | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. A few warnings were being triggered because of this (the result of the integral is an array of size 1 instead of a scalar, which numpy doesn't like). |
||
|
||
# now do scale factor integral | ||
return self._integrator(mint, a) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have you checked that this doesn't break other CCL stuff that might have been updated to numpy 2?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The opposite, actually. We cannot yet move to numpy 2 because many of our dependencies still don't use numpy 2. firecrown is in the same situation. This will be a tricky migration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also want to add this
numpy<2
in the pyproject.toml dependencies.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done