Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nikosarcevic ccl v3 paper plots #1161

Open
wants to merge 15 commits into
base: master
Choose a base branch
from

Conversation

nikosarcevic
Copy link
Contributor

No description provided.

this needs a review, just to make sure we are on the same track

in particular, I would appreciate if someone can check if baryons halo model output makes sense
@coveralls
Copy link

coveralls commented Feb 21, 2024

Pull Request Test Coverage Report for Build 8990731360

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 20 unchanged lines in 4 files lost coverage.
  • Overall coverage decreased (-0.006%) to 97.458%

Files with Coverage Reduction New Missed Lines %
pyccl/cosmology.py 2 99.52%
pyccl/baryons/baccoemu_baryons.py 3 96.25%
pyccl/tracers.py 4 95.13%
pyccl/halos/pk_4pt.py 11 96.14%
Totals Coverage Status
Change from base Build 7986188385: -0.006%
Covered Lines: 6556
Relevant Lines: 6727

💛 - Coveralls

@nikosarcevic
Copy link
Contributor Author

this needs a review for the baryons halo model only. everything else has been checked

the review is needed as I am not sure if what comes out of the halo model notebook and then plotted together with the other baryon models makes sense

…wer_spectra.ipynb

renamed the notebook from "spectrum" to "spectra"
fixed a typo, rearranged the color scheme a bit to help with the visualisations
recalculated baryon hm added to the rest of baryon models plots
i was missing the prefactors for each components when I am comparing to Pk nonlinear. those prefactors are now included
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants