Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dense matrix needs RAJA when GPU is used #676

Merged
merged 4 commits into from
Feb 5, 2024
Merged

Dense matrix needs RAJA when GPU is used #676

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8cb2c10
dense matrix needs RAJA when GPU is used
nychiang Dec 18, 2023
2400342
update CMakeList
nychiang Jan 31, 2024
dc3b11b
add a description
nychiang Feb 2, 2024
b533dc5
have an error message when GPU is on but raja is off.
nychiang Feb 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,10 @@ else()
endif()

if(HIOP_USE_GPU)
if(NOT HIOP_USE_RAJA)
message(FATAL_ERROR "Error: HIOP_USE_GPU is ON, but HIOP_USE_RAJA is OFF. HiOp requires using RAJA with CUDA/HIP.")
endif()

include(CheckLanguage)
if(HIOP_USE_MAGMA)
set(HIOP_MAGMA_DIR CACHE PATH "Path to Magma directory")
Expand Down
2 changes: 1 addition & 1 deletion src/LinAlg/LinAlgFactory.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,7 +353,7 @@ hiopMatrixDense* LinearAlgebraFactory::create_matrix_dense(const ExecSpaceInfo&
return nullptr;
#endif //HIOP_USE_RAJA
} else {// for if(hi.exec_backend_ == "RAJA")

assert(false && "device memory backend not available because HiOp was not built with RAJA");
if(mem_space_upper == "CUDA") {
#ifdef HIOP_USE_CUDA
assert(mem_space_upper == "DEVICE");
Expand Down
Loading