This repository has been archived by the owner on Jul 22, 2019. It is now read-only.
Support deploying on Google App Engine #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of running the entire build as sudo (ie: the recommended "sudo make"), only use sudo for the 2 commands that need it. This avoids having all of the build artifacts generated with the wrong owner:group. Signed-off-by: Sean Paul <[email protected]>
It's used in more than testing, so put it somewhere where the app and testing infra can access it. Signed-off-by: Sean Paul <[email protected]>
Add a bit of configuration and logic to support Google Cloud SQL instances Signed-off-by: Sean Paul <[email protected]>
It's unsupported and (AFAICT) unnecessary Signed-off-by: Sean Paul <[email protected]>
App Engine app.yaml needs wsgi script to have .py extension Signed-off-by: Sean Paul <[email protected]>
Add a couple of App Engine specific files and add some instructions to README.md to allow deployment to Google App Engine. Signed-off-by: Sean Paul <[email protected]>
Signed-off-by: Sean Paul <[email protected]>
Instead of incurring the additional overhead and space of the b64 encoding, decode the file when saving. Signed-off-by: Sean Paul <[email protected]>
Signed-off-by: Sean Paul <[email protected]>
Signed-off-by: Sean Paul <[email protected]>
Signed-off-by: Sean Paul <[email protected]>
Signed-off-by: Sean Paul <[email protected]>
Signed-off-by: Sean Paul <[email protected]>
Signed-off-by: Sean Paul <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just set this up on GAE and figured I'd send my patch stack along. I think the only controversial thing here is the .wsgi -> .py rename patch, but unfortunately that's required to get things going. I considered just making a copy of the file since it's small, but that seemed less desirable.