Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature/larpandoracontent_v04_10_00 #66

Merged

Conversation

AndyChappell
Copy link

This PR for larpandoracontent version v04_10_00 contains updates to the Hierarchy Validation. This ensures events with missing PFO vertex or interaction code information are still considered for metrics and allows simultaneous production of Event and MC trees. Additional configuration options and output variables are introduced. This will not alter the products for any existing workflows.

jback08 and others added 3 commits August 9, 2024 15:20
…ices.

Allow both the Event and MC hierarchy ROOT files to be created together.
Allow the reconstructability criteria to be modified by xml parameters.
Add reco and true MC vertex coordinates to the ROOT output.
@FNALbuild
Copy link

A new Pull Request was created by @AndyChappell for develop.

It involves the following packages:

larpandoracontent

@LArSoft/level-2-managers, @LArSoft/level-1-managers can you please review it and eventually sign? Thanks.

cms-bot commands are listed here

@FNALbuild
Copy link

The code-checks are being triggered in jenkins.

@FNALbuild
Copy link

+code-checks

@knoepfel
Copy link
Member

trigger build

@FNALbuild
Copy link

The tests are being triggered in jenkins.

@FNALbuild
Copy link

@FNALbuild
Copy link

@FNALbuild
Copy link

@FNALbuild
Copy link

-SBND tests warning, with build warning,, with ignored warning for build, on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:SBND/view_builds/index?offset=0&builds=sbnd_ci/14763&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/23447&builds=

@FNALbuild
Copy link

-ICARUS tests warning, with build warning,, with ignored warning for build, on slf7 for e26:prof
for details see
https://lar-ci-history.fnal.gov/LarCI/app/ns:ICARUS/view_builds/index?offset=0&builds=icarus_ci/10456&builds=
for details of the parent CI build see
https://lar-ci-history.fnal.gov/LarCI/app/view_builds/index?offset=0&builds=lar_ci/23447&builds=

@FNALbuild
Copy link

@lgarren
Copy link
Member

lgarren commented Aug 19, 2024

approve

@FNALbuild
Copy link

This pull request is fully signed and it will be merged to develop and built in the next LArSoft release after it passes the integration tests.

@lgarren lgarren merged commit 866d784 into LArSoft:develop Aug 22, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Included in release
Development

Successfully merging this pull request may close these issues.

5 participants