Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nuance code for supernova neutrinos #42

Merged
merged 1 commit into from
Oct 22, 2024

Conversation

AndyChappell
Copy link
Contributor

Pandora uses the nuance code in some decision making e.g. does this particle come from a neutrino interaction or a cosmic ray. MARLEY sets nuance codes to 0, which breaks a lot of the logic in the decision making. This update adds an override to Pandora's internal nuance code override for supernova origin particles (code==4000).

@FNALbuild
Copy link
Contributor

A new Pull Request was created by @AndyChappell for develop.

It involves the following packages:

larpandora

@LArSoft/level-2-managers, @LArSoft/level-1-managers can you please review it and eventually sign? Thanks.

cms-bot commands are listed here

@FNALbuild
Copy link
Contributor

The code-checks are being triggered in jenkins.

@FNALbuild
Copy link
Contributor

+code-checks

@FNALbuild
Copy link
Contributor

The tests are being triggered in jenkins.
Tested with other pull request(s) LArSoft/larpandoracontent#67

@FNALbuild
Copy link
Contributor

@FNALbuild
Copy link
Contributor

@FNALbuild
Copy link
Contributor

@FNALbuild
Copy link
Contributor

@FNALbuild
Copy link
Contributor

@FNALbuild
Copy link
Contributor

@lgarren
Copy link
Member

lgarren commented Oct 21, 2024

approve

@FNALbuild
Copy link
Contributor

This pull request is fully signed and it will be merged to develop and built in the next LArSoft release after it passes the integration tests.

@lgarren lgarren merged commit 1f4cab6 into LArSoft:develop Oct 22, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Included in release
Development

Successfully merging this pull request may close these issues.

4 participants