Add timeout to requests calls

[pixeeai]

Many developers will be surprised to learn that requests library calls do not include timeouts by default. This means that an attempted request could hang indefinitely if no connection is established or if no data is received from the server.

The requests documentation suggests that most calls should explicitly include a timeout parameter. This codemod adds a default timeout value in order to set an upper bound on connection times and ensure that requests connect or fail in a timely manner. This value also ensures the connection will timeout if the server does not respond with data within a reasonable amount of time.

While timeout values will be application dependent, we believe that this codemod adds a reasonable default that serves as an appropriate ceiling for most situations.

Our changes look like the following:

 import requests
 
- requests.get("http://example.com")
+ requests.get("http://example.com", timeout=60)

More reading

• https://docs.python-requests.org/en/master/user/quickstart/#timeouts

Powered by: pixeebot (codemod ID: pixee:python/add-requests-timeouts)

[pixeeai]

FYI - This change was autogenerated from a GitHub app - called Pixeebot. A code-quality GitHub App; like Dependabot, but for source code. Feel free to check it our for more details for how you can install it onto your project's repo for continued code hardening and code security recommendations.

[github-actions]

❌ pre-commit failed.
Please run pre-commit run --all-files locally and commit the changes.
Find more information in the repository's CONTRIBUTING.md

[github-actions]

❌ pre-commit failed.
Please run pre-commit run --all-files locally and commit the changes.
Find more information in the repository's CONTRIBUTING.md

[github-actions]

❌ pre-commit failed.
Please run pre-commit run --all-files locally and commit the changes.
Find more information in the repository's CONTRIBUTING.md

[pixeeai]

Any chance you've had the time to review these changes?

If you're not interested implementing them at this time, no worries. I can close the PR and follow up with additional changes in the future. Also, this plugin is free for non-commercial open sourced projects, so feel free to give it an install if you want to see the other recommended PRs. (GitHub Apps - pixeebot)

Thanks,
Zach

[x64x2]

Stop Contributing, Project been dead for months now

[bitplane]

@pixeeai Please inform your owner that they should not blindly change random functions in machine learning projects. secure random number generators add nothing but overhead, and where the previous generator was used with a known seed, you risk messing up the training and test data splits.

[pixeeai]

Stop Contributing, Project been dead for months now

Apologies, was not aware it was the development has paused.

Thanks,
Zach

[pixeeai]

@pixeeai Please inform your owner that they should not blindly change random functions in machine learning projects. secure random number generators add nothing but overhead, and where the previous generator was used with a known seed, you risk messing up the training and test data splits.

Apologies as well, the intended changes were specifically for adding timeout values to the requests. Did not mean to pull in the other changes regarding the random number generator.

This is what it was intended to be pulled from:
https://github.com/Pixee-Bot-Python/Open-Assistant/pull/5/files

Sorry again!

Take care,
Zach