Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: LastActive stale report / added functionality #9

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

amadeo-alex
Copy link

@amadeo-alex amadeo-alex commented Jun 30, 2023

This PR:

To be specific, following checks are made (in order):

  • is the function enabled
  • was system woken from sleep/hibernation
  • wasn't there any user input after system has been woken from sleep/hibernation
  • are we within specified time window
    If they all pass mouse is repositioned to generate the event.

By default the behaviour stays the same to preserve the compatibility and because from the practical standpoint the sensor is working correctly - reporting last "user input".

This implementation repurposes default "round" UI controls for simplicity sake, not a clean solution but will work for now :)
obraz

Note: for some reason Visual Studio replaced web encoded quotes/apostrophes with normal ones. I couldn't spot an issue with it but if required I can replace them manually I think.

@amadeo-alex amadeo-alex marked this pull request as ready for review June 30, 2023 15:57
@srmagm
Copy link

srmagm commented Jul 1, 2023

Great, this is exactly what I was looking for, I'm kind of new to this github pull request world, when will this bugfix be available? Or if it is already available where can I download the updated version? best regards and apologies if this is not the place to ask this. Great work

@LAB02-Admin
Copy link
Member

Great, this is exactly what I was looking for, I'm kind of new to this github pull request world, when will this bugfix be available? Or if it is already available where can I download the updated version? best regards and apologies if this is not the place to ask this. Great work

Yea pretty awesome :) I'll be publishing a beta soon which'll contain this PR, so if you want to help out, check Notify me of beta releases in HASS.Agent's config page:

image

You'll get an update notification as soon as I publish the beta. Let us know if something's not working as it should, so we can have everything smoothened out for the final release :)

@srmagm
Copy link

srmagm commented Jul 1, 2023

I really apreciate to hear that, thank you very much for your quick response, im going to activate now, i will give feedback when i recive the update, Great work guys this project is amazing! :D

@amadeo-alex amadeo-alex changed the title LastActive stale report fix / added functionality Fix: LastActive stale report / added functionality Jul 16, 2023
@pmalecka
Copy link

pmalecka commented Oct 1, 2023

@LAB02-Admin I'd like to give this a try. Is the beta released yet?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants