-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: notification library change to Windows APP SDK / misc. improvements&features #18
Open
amadeo-alex
wants to merge
27
commits into
LAB02-Research:main
Choose a base branch
from
hass-agent:feature-app-sdk
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with strange launch arguments
…tionality that was started some time ago
…ccount for actionable notifications functionality
…egarding BinaryFormatter security issues
amadeo-alex
changed the title
Feature: notification library change to Windows APP SDK / User input support
Feature: notification library change to Windows APP SDK / user input support / activation when HASS.Agent is not running
Jul 24, 2023
|
2 tasks
|
amadeo-alex
changed the title
Feature: notification library change to Windows APP SDK / user input support / activation when HASS.Agent is not running
Feature: notification library change to Windows APP SDK / misc. improvements&features
Jul 25, 2023
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
file:///C:/Users/Amadeo/Desktop/temp/sumCat.jpg
)Login attempt or request with invalid authentication from HOSTNAME (IPADDRESS). Requested URL: '/api/events/hass_agent_notifications'. (None)
error in HA)Reason for the library change is the M$ recommendation when "registry issues" occur with UWP Toolkit, apparently they do not plan on tackling the issue (microsoft/microsoft-ui-xaml#5689)
Should remediate/fix following issues:
Due to Windows APP SDK shipping with it's own WebView2 instead of making it a nuget dependency (microsoft/microsoft-ui-xaml#5689), the WebView2 which we originally used needs to be wrapped in an alias.
@LAB02-Admin Windows APP SDK requires installation of an additional user facing appx package - https://learn.microsoft.com/en-us/windows/apps/windows-app-sdk/downloads. Should this be included as part of the installation application?
If it is not installed, user is prompted with following message during HASS.Agent launch:
Clicking on "Yes" redirects to the download page mentioned above.
Appx packages before and after installation:
Additional notification settings regarding URI (defaults to false to maintain backwards compatibility):
Example of notification, where clicking "Open URI" will open a site with cat pics:
New test notification:
Regarding the miscellaneous "user input", it works exactly the same as button options.
Example, this HA service call
produces following notification on my machine
If at the same time following automation is configured within HA
filling in text box with "SomeAwesomeText" and clicking "Yes", causes following new notification to appear
@LAB02-Admin this certainly would require adjustments in the documentation, I'll gladly do them but I couldn't find the repository :D