Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: quick action carousel/circular navigation #15

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

amadeo-alex
Copy link

@amadeo-alex amadeo-alex commented Jul 16, 2023

This PR adds features to the Quick Actions window requested by @ASchneiderBR in LAB02-Research/HASS.Agent#327

Detailed changes (Edited as per below discussion):

  • first item should be always selected when Quick Actions window is displayed
  • pressing left arrow key selects the next item to the left unless there is none, then first item in the next row below is selected
  • pressing right arrow key selects previous item to the right unless there is none, then last item in the above row is selected
  • pressing left/right arrow key when "first" or "last" in general is selected causes the selection to wrap up to the end/begining
  • pressing up/down arrow key moves selection respective to the column
  • pressing the Quick Action shortcut repeatedly while Quick Action window is opened will cause the next Quick Action item to be selected (in order of right -> down -> up)

Video presenting the new behaviour: (white text box shows which keyboard keys are being pressed)

devenv_D4DzX7nONl.mp4

@amadeo-alex amadeo-alex marked this pull request as ready for review July 16, 2023 20:09
@ASchneiderBR
Copy link

ASchneiderBR commented Jul 16, 2023

Hello @amadeo-alex,

I am grateful for your prompt response! I apologize if my previous message was unclear, English isn't my first language and it appears I may not have conveyed my thoughts as intended.

My idea differs somewhat from what is shown in the video. Primarily, I'm concerned with the functionality of the quick actions hotkey. Currently, when I press it, the menu appears and displays several options across a few rows. Using the keyboard arrow keys left and right, I can navigate horizontally across these options.

However, once I reach the end of a row and press the 'right' arrow key, it loops back to the first option in the same row. I propose that instead of looping within the same row, pressing the 'right' arrow key when at the end of a row should move the selection to the first item in the next row.

Furthermore, I propose a change in the method of option selection. Rather than pressing 'Enter' to select an active item, I believe it would be more efficient to use the same quick actions hotkey to select the item. This would eliminate the need for an additional key press.

Thank you once again for your time and consideration. I look forward to hearing your thoughts on these suggestions.

@amadeo-alex
Copy link
Author

amadeo-alex commented Jul 17, 2023

Hello @ASchneiderBR,
Don't worry, English isn't my first language either so it might be me :D

I've changed how the left/right arrow key press behaves - to what you described, it now wraps to the next/previous row or to the first/last item if pressed at the "beginning or end" of the item list. I've also update the feature description and video to reflect the change. Please check it and let me know if that's what you've meant :)

Regarding the Quick Action shortcut performing the action, I'd say this is not a good idea for one reason, human error. People may click the Ctrl+Alt+Q (if set to the default of course) twice by accident and trigger something they didn't intend to. This wouldn't be intuitive.

@ASchneiderBR
Copy link

ASchneiderBR commented Jul 17, 2023

Hi, I appreciate your response. I see what you mean about using the same hotkey for the quick action menu and cycling through the options :) Maybe we can combine both ideas: use left/right arrow to switch items and the main hotkey as you suggested. I want to use the knob on my macropad, so I only have left, right and middle (knob click) commands. I can assign the right action to the quick action hotkey and knob click as enter. A reverse order hotkey would be cool haha Thanks a lot and have a great week!

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants