refactor: update limit order logic #637
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoanguyenkh
requested review from
piavgh,
it4rb,
NgoKimPhu and
lehainam-dev
as code owners
hieuvo
reviewed
Dec 6, 2024
| feeAmountWeiByOrder = p.calcFeeAmountPerOrder(order, remainingTakingAmountWei) | ||
| } else { | ||
| feeAmountWeiByOrder = p.calcFeeAmountPerOrder(order, remainingMakingAmountWei) | ||
| } | ||
| actualAmountOut := new(big.Int).Sub(remainingMakingAmountWei, feeAmountWeiByOrder) |
There was a problem hiding this comment.
actualAmountOut := new(big.Int).Sub(remainingMakingAmountWei, feeAmountWeiByOrder)in case of order.IsTakerAssetFee = true, the logic of this line doesn't make sense anymore, we have to
// psuedo code, not tested
remainingTakingAmountWei = remainingTakingAmountWei - feeAmountWeiByOrder
actualAmountOut := remainingTakingAmountWei * order.MakingAmount / order.TakingAmount
hieuvo
reviewed
Dec 6, 2024
| feeAmountWeiByOrder = p.calcFeeAmountPerOrder(order, filledTakingAmountWei) | ||
| } else { | ||
| feeAmountWeiByOrder = p.calcFeeAmountPerOrder(order, filledMakingAmountWei) | ||
| } | ||
| totalFeeAmountWei = new(big.Int).Add(totalFeeAmountWei, feeAmountWeiByOrder) | ||
| actualAmountOut := new(big.Int).Sub(filledMakingAmountWei, feeAmountWeiByOrder) |
|
Move to -> #643 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why did we need it?
For new logic fee merchanism we add a new field
IsTakerAssetFeein the order payload,New logic is:
Related Issue
Release Note
How Has This Been Tested?
Screenshots (if appropriate):