Run next action on failure when failuremode is allow #157
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,168 @@ | ||
| use crate::util::common::wasm_module; | ||
| use proxy_wasm_test_framework::tester; | ||
| use proxy_wasm_test_framework::types::{Action, BufferType, LogLevel, MapType, ReturnType}; | ||
| use serial_test::serial; | ||
|
|
||
| pub mod util; | ||
|
|
||
| #[test] | ||
| #[serial] | ||
| fn it_runs_next_action_on_failure_when_failuremode_is_allow() { | ||
| let args = tester::MockSettings { | ||
| wasm_path: wasm_module(), | ||
| quiet: false, | ||
| allow_unexpected: false, | ||
| }; | ||
| let mut module = tester::mock(args).unwrap(); | ||
|
|
||
| module | ||
| .call_start() | ||
| .execute_and_expect(ReturnType::None) | ||
| .unwrap(); | ||
|
|
||
| let root_context = 1; | ||
| let cfg = r#"{ | ||
| "services": { | ||
| "limitador": { | ||
| "type": "ratelimit", | ||
| "endpoint": "limitador-cluster", | ||
| "failureMode": "deny", | ||
| "timeout": "5s" | ||
| }, | ||
| "limitador-unreachable": { | ||
| "type": "ratelimit", | ||
| "endpoint": "unreachable-cluster", | ||
| "failureMode": "allow", | ||
| "timeout": "5s" | ||
| } | ||
| }, | ||
| "actionSets": [ | ||
| { | ||
| "name": "some-name", | ||
| "routeRuleConditions": { | ||
| "hostnames": ["example.com"] | ||
| }, | ||
| "actions": [ | ||
| { | ||
| "service": "limitador-unreachable", | ||
| "scope": "a", | ||
| "data": [ | ||
| { | ||
| "expression": { | ||
| "key": "l", | ||
| "value": "1" | ||
| } | ||
| } | ||
| ] | ||
| }, | ||
| { | ||
| "service": "limitador", | ||
| "scope": "a", | ||
| "data": [ | ||
| { | ||
| "expression": { | ||
| "key": "l", | ||
| "value": "1" | ||
| } | ||
| } | ||
| ] | ||
| }] | ||
| }] | ||
| }"#; | ||
|
|
||
| module | ||
| .call_proxy_on_context_create(root_context, 0) | ||
| .expect_log(Some(LogLevel::Info), Some("#1 set_root_context")) | ||
| .execute_and_expect(ReturnType::None) | ||
| .unwrap(); | ||
| module | ||
| .call_proxy_on_configure(root_context, 0) | ||
| .expect_log(Some(LogLevel::Info), Some("#1 on_configure")) | ||
| .expect_get_buffer_bytes(Some(BufferType::PluginConfiguration)) | ||
| .returning(Some(cfg.as_bytes())) | ||
| .expect_log(Some(LogLevel::Info), None) | ||
| .execute_and_expect(ReturnType::Bool(true)) | ||
| .unwrap(); | ||
|
|
||
| let http_context = 2; | ||
| module | ||
| .call_proxy_on_context_create(http_context, root_context) | ||
| .expect_log(Some(LogLevel::Debug), Some("#2 create_http_context")) | ||
| .execute_and_expect(ReturnType::None) | ||
| .unwrap(); | ||
|
|
||
| let first_call_token_id = 42; | ||
| module | ||
| .call_proxy_on_request_headers(http_context, 0, false) | ||
| .expect_log(Some(LogLevel::Debug), Some("#2 on_http_request_headers")) | ||
| .expect_get_header_map_value(Some(MapType::HttpRequestHeaders), Some(":authority")) | ||
| .returning(Some("example.com")) | ||
| .expect_log( | ||
| Some(LogLevel::Debug), | ||
| Some("#2 action_set selected some-name"), | ||
| ) | ||
| // retrieving tracing headers | ||
| .expect_get_header_map_value(Some(MapType::HttpRequestHeaders), Some("traceparent")) | ||
| .returning(None) | ||
| .expect_get_header_map_value(Some(MapType::HttpRequestHeaders), Some("tracestate")) | ||
| .returning(None) | ||
| .expect_get_header_map_value(Some(MapType::HttpRequestHeaders), Some("baggage")) | ||
| .returning(None) | ||
| .expect_grpc_call( | ||
| Some("unreachable-cluster"), | ||
| Some("envoy.service.ratelimit.v3.RateLimitService"), | ||
| Some("ShouldRateLimit"), | ||
| Some(&[0, 0, 0, 0]), | ||
| None, | ||
| Some(5000), | ||
| ) | ||
| .returning(Ok(first_call_token_id)) | ||
| .expect_log( | ||
| Some(LogLevel::Debug), | ||
| Some("#2 initiated gRPC call (id# 42)"), | ||
| ) | ||
| .execute_and_expect(ReturnType::Action(Action::Pause)) | ||
| .unwrap(); | ||
|
|
||
| let status_code = 14; | ||
| module | ||
| .proxy_on_grpc_close(http_context, 42, status_code) | ||
| .expect_log( | ||
| Some(LogLevel::Debug), | ||
| Some(format!("#2 on_grpc_call_response: received gRPC call response: token: {first_call_token_id}, status: {status_code}").as_str()), | ||
| ) | ||
| .expect_get_buffer_bytes(Some(BufferType::GrpcReceiveBuffer)) | ||
| .returning(Some(&[])) | ||
| .expect_grpc_call( | ||
| Some("limitador-cluster"), | ||
| Some("envoy.service.ratelimit.v3.RateLimitService"), | ||
| Some("ShouldRateLimit"), | ||
| Some(&[0, 0, 0, 0]), | ||
| Some(&[ | ||
| 10, 1, 97, 18, 28, 10, 26, 10, 21, 108, 105, 109, 105, 116, 95, 116, 111, 95, 98, | ||
| 101, 95, 97, 99, 116, 105, 118, 97, 116, 101, 100, 18, 1, 49, 24, 1, | ||
| ]), | ||
|
Comment on lines
+141
to
+144
There was a problem hiding this comment. Do we want to use |
||
| Some(5000), | ||
| ) | ||
| .returning(Ok(42)) | ||
| .execute_and_expect(ReturnType::None) | ||
| .unwrap(); | ||
|
|
||
| let grpc_response: [u8; 2] = [8, 1]; | ||
| module | ||
| .call_proxy_on_grpc_receive(http_context, 42, grpc_response.len() as i32) | ||
| .expect_log( | ||
| Some(LogLevel::Debug), | ||
| Some("#2 on_grpc_call_response: received gRPC call response: token: 42, status: 0"), | ||
| ) | ||
| .expect_get_buffer_bytes(Some(BufferType::GrpcReceiveBuffer)) | ||
| .returning(Some(&grpc_response)) | ||
| .execute_and_expect(ReturnType::None) | ||
| .unwrap(); | ||
|
|
||
| module | ||
| .call_proxy_on_response_headers(http_context, 0, false) | ||
| .expect_log(Some(LogLevel::Debug), Some("#2 on_http_response_headers")) | ||
| .execute_and_expect(ReturnType::Action(Action::Continue)) | ||
| .unwrap(); | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we just leave this out and have it hard-coded the same as the second token? or use a diff token than 42 for both?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would use a diff token, as this is the case when running on the host.