Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement build precheck #85

Merged
merged 22 commits into from
Nov 8, 2023
Merged

Implement build precheck #85

merged 22 commits into from
Nov 8, 2023

Conversation

snthtcs
Copy link
Contributor

@snthtcs snthtcs commented Nov 8, 2023

This PR introduces a build step pre-check on GitHub actions that will be triggered every time a new PR against develop is created.

How it works:


  1. Dev opens PR to develop
  2. Skaffold build is triggered
  3. If new modifications are done to the PR while its open step 2 is re-triggered
  4. After PR is merged the normal pipeline gets executed (build+push+deploy)
  5. You can't get your PR merged if the pre-check pipeline isn't green, so it needs to finish first

To achieve this:

  • New pipeline kread-skaffold-precheck.yml
  • Branch protection rule at repo level

@snthtcs snthtcs requested a review from carlos-kryha as a code owner November 8, 2023 11:00
@snthtcs snthtcs merged commit 7e5fe83 into develop Nov 8, 2023
3 checks passed
@snthtcs snthtcs deleted the build_step branch November 8, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlos-kryha carlos-kryha carlos-kryha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@snthtcs @carlos-kryha