Skip to content

Commit

Permalink
small fixes and divide contract and frontend bug templates
Browse files Browse the repository at this point in the history
  • Loading branch information
Pandelis Symeonidis committed Nov 17, 2023
1 parent 8bcfc33 commit e791bb0
Show file tree
Hide file tree
Showing 5 changed files with 116 additions and 42 deletions.
41 changes: 0 additions & 41 deletions .github/ISSUE_TEMPLATE/bug_report.yml

This file was deleted.

54 changes: 54 additions & 0 deletions .github/ISSUE_TEMPLATE/contract_bug_report.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
name: Contract Bug Report
description: "Use this template to report a contract side bug."
title: "BUG: CONTRACT: [BUG DESCRIPTION]"
labels: [bug]
body:
- type: textarea
attributes:
label: Bug description
description: Provide a clear description of the bug you encountered.
placeholder: Unequipping mask items is not working. Clicking the unequip button from the inventory page on a mask item has no effect.
validations:
required: true
- type: textarea
attributes:
label: Repro
description: List the steps needed to reproduce the bug. Be as clear and detailed as possible.
placeholder: |
1. Go to the inventory page
2. Find a mask item that is equipped to some character
3. Click the unequip button
4. Observe that nothing happens
validations:
required: true
- type: textarea
attributes:
label: Expected behavior
description: Describe the expected behavior.
placeholder: Clicking the unequip button should trigger the kepler wallet to approve my transaction and remove the item from the characters inventory.
validations:
required: true
- type: input
attributes:
label: Agoric-sdk version
description: What branch of the agoric-sdk are you using?
validations:
required: true
- type: input
attributes:
label: Branch
description: What branch of the KREAd repo were you using when you encountered the bug?
validations:
required: false
- type: textarea
attributes:
label: Screenshots/Videos
description: Optionally provide a screenshot or demo of the bug.
validations:
required: false
- type: textarea
attributes:
label: Additional info
description: For anything else you want to add!
validations:
required: false
2 changes: 1 addition & 1 deletion .github/ISSUE_TEMPLATE/feature_request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ body:
- type: textarea
attributes:
label: Acceptance criteria
description: Descibe what should be done for this issue to be considered closed.
description: Describe what should be done for this issue to be considered closed.
validations:
required: true
- type: textarea
Expand Down
60 changes: 60 additions & 0 deletions .github/ISSUE_TEMPLATE/frontend_bug_report.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,60 @@
name: Bug Report
description: "Use this template to report a frontend side bug."
title: "BUG: FRONTEND: [BUG DESCRIPTION]"
labels: [bug]
body:
- type: textarea
attributes:
label: Bug description
description: Provide a clear description of the bug you encountered.
placeholder: Unequipping mask items is not working. Clicking the unequip button from the inventory page on a mask item has no effect.
validations:
required: true
- type: textarea
attributes:
label: Repro
description: List the steps needed to reproduce the bug. Be as clear and detailed as possible.
placeholder: |
1. Go to the inventory page
2. Find a mask item that is equipped to some character
3. Click the unequip button
4. Observe that nothing happens
validations:
required: true
- type: textarea
attributes:
label: Expected behavior
description: Describe the expected behavior.
placeholder: Clicking the unequip button should trigger the kepler wallet to approve my transaction and remove the item from the characters inventory.
validations:
required: true
- type: input
attributes:
label: Branch
description: If you ran the frontend locally, what branch are you on?
validations:
required: false
- type: input
attributes:
label: Connected Network
description: What network is the frontend connected to (local, emerynet, mainnet).
validations:
required: true
- type: input
attributes:
label: Contract branch
description: If connected to a local chain, what branch are you on when running the chain?
validations:
required: false
- type: textarea
attributes:
label: Screenshots/Videos
description: Optionally provide a screenshot or demo of the bug.
validations:
required: false
- type: textarea
attributes:
label: Additional info
description: For anything else you want to add!
validations:
required: false
1 change: 1 addition & 0 deletions .github/PULL_REQUEST_TEMPLATE/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ Make sure all items are checked before submitting the pull request. Remove any i
- [ ] I have added/updated unit tests to cover the changes.
- [ ] All existing tests pass.
- [ ] The PR title is clear and concise.
- [ ] Are there changes in the /fronted folder? Make sure `cd frontend && yarn build` runs successfully.;

## Additional Notes

Expand Down

0 comments on commit e791bb0

Please sign in to comment.