-
-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Gallery] Bug fix, Feature Update #228
Conversation
- Bug fix - where the cog was listening to bots messages causing it to fall in a potential loop of 'deleting-sending-deleting'. - (For example: In case of a sticky msg in the 'set gallery' channel the cog would keep on deleting the sticked message while the sticky cog would keep on sending a new message) - **Bots are Ignored now**. - The `galleryset add` and `galleryset remove` commands now accepts **multiple channel** as arguments. - Removed colons from `:` settings embed making it more user-readable. - Bumped the version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Thanks very much for making those changes.
One small thing, a bit of a nitpick, could the added VS already added messages be sent together, with a line break or something? Sending two messages at once isn't necessary and may cause unexpected behavior if it interferes with certain listeners with cooldown functionality. I'm referring to:
if added_channels:
await ctx.send(f"{', '.join(added_channels)} added to the Gallery channels list.")
if already_in_list:
await ctx.send(f"{', '.join(already_in_list)} already in the Gallery channels list.")
if removed_channels:
await ctx.send(f"{', '.join(removed_channels)} removed from the Gallery channels list.")
if not_in_list:
await ctx.send(f"{', '.join(not_in_list)} not in the Gallery channels list.")
- Added sending response in one message instead of sending multiple. - `galleryset role` will mention the role as `<@&ID>` instead of role_name. - No change in settings embed, it'd still show the roles in **name** format (instead of mention) as mentioning roles require the user-client to be cached, before showing up properly. - Slight adjustment to the regex: > Previous: `[!*\(\\),]` > New: `[!*\\(\\),]` - This portion of the regex matches the literal characters: `!` `*` `(` `)` `,` - where the 1st parenthesis `(` wasn't properly escaped with `\\`
Oh yes! absolutely, Done.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks very much for contributing!
Hi Kreu,
Noticed this bug today so decided to pr the changes:
galleryset add
andgalleryset remove
commands now accept multiple channel as arguments.:
settings embed making it more user-readable.showsettings
,show
,setting
(Hope its okay )Type