Initial support LLVM Intel in Windows #363
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loumalouomega
requested review from
philbucher and
pooyan-dadvand
as code owners
philbucher
reviewed
Oct 27, 2023
There was a problem hiding this comment.
can you please explain why these changes are required?
Seems like a wrong commit to int should also work in Win :D
|
When I first I tried to compile with strict it was complaining about that
(not used in Windows). Then I decided to give up with the strict because I
needed to change the async io library.
El vie., 27 oct. 2023 19:00, Philipp Bucher ***@***.***>
escribió:
… ***@***.**** commented on this pull request.
------------------------------
On co_sim_io/includes/communication/pipe_communication.hpp
<#363 (comment)>
:
can you please explain why these changes are required?
Seems like a wrong commit to int should also work in Win :D
—
Reply to this email directly, view it on GitHub
<#363 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEYQZAH2HGSOUK7IK3TTVZLYBPSBVAVCNFSM6AAAAAA6S6H47KVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTOMBSGIYDINZZHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
I can merge because you approved or because branch is not protected? @philbucher |
philbucher
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the 'scripts/build.bat' file. The changes include setting the compiler variables 'CC' and 'CXX' based on the value of 'USE_INTEL_LLVM', and adjusting the 'CO_SIM_IO_STRICT_COMPILER' setting accordingly. When 'USE_INTEL_LLVM' is 'ON', it sets the compiler to 'icx-cl.exe' and turns off the strict compiler mode, as the Intel LLVM compiler fails with strict compiler settings.
When 'USE_INTEL_LLVM' is 'OFF', it sets the compiler to 'cl.exe' and turns on the strict compiler mode.
These changes are required fir for proper compilation on Windows systems when using the Intel LLVM compiler.