Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix code loc win #352

Merged
merged 13 commits into from
Sep 7, 2023
Merged

Fix code loc win #352

merged 13 commits into from
Sep 7, 2023

Conversation

philbucher
Copy link
Member

fixes #350

FYI @loumalouomega this is a slightly improved version of #351, including a test

@loumalouomega
Copy link
Member

Huuuuum, test failing

@philbucher
Copy link
Member Author

Why is it always windows 🙈
At least we are narrowing down the problem

Interesting to see the differences, in particular of the function name macro.
In linux the namespace is added too, does not seem to be the case in windows

@loumalouomega
Copy link
Member

Why is it always windows 🙈 At least we are narrowing down the problem

Interesting to see the differences, in particular of the function name macro. In linux the namespace is added too, does not seem to be the case in windows

And the intel CI is still failing

@philbucher
Copy link
Member Author

I am pretty sure I found the actual cause of the problem, I think I can fix it tonight

@philbucher
Copy link
Member Author

merging now, the CI failures are unrelated

FYI @pooyan-dadvand the real source of the error was that there were some bugs in the filesystem implementation that we use, in particular the fs::canonicial implementation.
These have been fixed in the meantime, I updated the lib now

Can you please try if it fixes the issues?

@philbucher philbucher merged commit 26e5bfc into master Sep 7, 2023
22 of 25 checks passed
@philbucher philbucher deleted the fix-code-loc-win branch September 7, 2023 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug in code location
2 participants