Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Experiencing Rate Limits Due to Feed Updates #596

Open
2 tasks done
PhantomShift opened this issue Dec 16, 2023 · 0 comments
Open
2 tasks done

Experiencing Rate Limits Due to Feed Updates #596

PhantomShift opened this issue Dec 16, 2023 · 0 comments
Labels
bug Something isn't working scope:tracker

Comments

@PhantomShift
Copy link

Brief summary

I am not entirely sure if this is a parser-specific issue, as I exclusively use Mangadex, but as far as I'm aware the relevant code is within this repository. Perhaps the main issue is the large number of manga I have in my history, but updating the feed seems to quickly run into Mangadex's rate limit and causes the client to no longer be able to fetch any data, making reading/updating impossible until the limit expires or my IP address changes.

I'm not very familiar with Kotatsu's code base as I've only inspected it lightly but I think that the relevant code which updates the feed doesn't impose a limit on itself (or that limit is still beyond Mangadex's limit of 5 requests per second) and just runs as many requests as possible until it finishes or an error occurs, most commonly a rate limit error, which may be related to why some manga appear to "never be updated" despite them having been updated whenever lots of manga are bookmarked.

I'm not sure if having lots of manga being updated in the feed was outside of expectations but having some sort of limit on the speed at which it updates would be greatly appreciated in order to avoid these problems in the future, assuming that is the problem.

Steps to reproduce

No response

Kotatsu version

6.4.2

Android version

13.0

Device

OnePlus 10T

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
  • If this is an issue with a parser, I should be opening an issue in the parsers repository.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working scope:tracker
Projects
None yet
Development

No branches or pull requests

2 participants