-
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add convenience configurator for collection paginators #100
Conversation
This API seems far too complex and domain-specific. The functions are, in general, pretty nuts - this is something that requires too much mental overhead to include as a user-facing API. What's your use-case for this? Why not just |
This seems like the most common use case for paginators, just listing a collection
Also, this is pretty similar to what JDA utilities does here: https://github.com/JDA-Applications/JDA-Utilities/blob/master/menu/src/main/java/com/jagrosh/jdautilities/menu/Paginator.java
|
Right, but you're not just listing a collection here, you're importing a collection with 4 separate required arguments most of which don't seem like they'd be useful for most people.
I have different ideas for lazy paginators that I'll be exploring in #90 - I don't think just throwing a flow into the builder is going to help much.
Eh, where? This is a 730 line file. |
There are 6 of them, but only 3 of them are actually required, and we could eliminate one of them if we add a function specifically for strings, and we could eliminate another one if we specify a default title
A page stores the builder as this |
That's really only technically lazy, not lazy in a meaningful way. Either way, the Flow has to be exhausted for the paginator to be shown - that's not ideal for several use-cases that I can think of.
Pages aren't... Strings, though? They're full embed builders. That was a deliberate choice for formatting flexibility, and it's been a suuuuuuper long time since pages were restricted this way. |
Marking this as stale as it hasn't had activity for well over a week. |
This has been stale for too long, so I'm closing it for now. I already had plans for this feature, so don't worry too much - it's just one of those things. |
Currently there isn't any easy way to cerate a paginator just for a list of items, this PR aims to fix that