Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ai-proxy): (multiple)(AG-154) fixed tools-functions calls coming back empty #13760

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

fix(ai-proxy): (multiple)(AG-154) fixed tools-functions calls coming back empty #13760

wants to merge 5 commits into from
+682 −84

Conversation

tysoekong
Copy link
Contributor

@tysoekong tysoekong commented Oct 16, 2024 •
edited
Loading

Summary

  • Fixes Bedrock, Gemini, Anthropic, Cohere function calling in AI-Proxy system (AG-154)
  • Fixes "image_url" type message not working in Bedrock (AG-155)

Checklist

  • The Pull Request has tests
  • A changelog file has been created under changelog/unreleased/kong or skip-changelog label added on PR if changelog is unnecessary. README.md
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Issue reference

AG-154
AG-155
AG-166

@github-actions github-actions bot added cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee plugins/ai-proxy labels Oct 16, 2024
@tysoekong tysoekong force-pushed the fix/AG-154_bedrock_gemini_function_calling branch from 18eccd6 to 7ebdfe3 Compare October 16, 2024 15:03
tysoekong
tysoekong commented Oct 16, 2024
View reviewed changes
kong/llm/drivers/gemini.lua
return new_r, "application/json", nil
end

local new_r = {}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was all duplicate from some rebase... somehow.

@tysoekong tysoekong marked this pull request as ready for review October 16, 2024 15:04
@tysoekong
Copy link
Contributor Author

@fffonion @subnetmarco Let's go

@team-gateway-bot team-gateway-bot added the author/community PRs from the open-source community (not Kong Inc) label Oct 16, 2024
@tysoekong
Copy link
Contributor Author

tysoekong commented Oct 16, 2024 •
edited
Loading

spec/03-plugins/39-ai-request-transformer/02-integration_spec.lua is a genuine failure. I never get this right first-go, argh.

I'll fix it...

@tysoekong tysoekong force-pushed the fix/AG-154_bedrock_gemini_function_calling branch 3 times, most recently from b5414c2 to 0124b09 Compare October 25, 2024 17:36
@team-eng-enablement team-eng-enablement removed the author/community PRs from the open-source community (not Kong Inc) label Nov 4, 2024
@tysoekong tysoekong force-pushed the fix/AG-154_bedrock_gemini_function_calling branch from 0124b09 to 073ce14 Compare November 5, 2024 16:24
oowl
oowl reviewed Nov 12, 2024
View reviewed changes
Copy link
Member

@oowl oowl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, we need some test for the current fix.

@tysoekong
Copy link
Contributor Author

@oowl I am on it

@tysoekong tysoekong force-pushed the fix/AG-154_bedrock_gemini_function_calling branch from 073ce14 to 6cf4b8b Compare November 13, 2024 03:18
@tysoekong
Copy link
Contributor Author

@oowl Added tests

@tysoekong tysoekong force-pushed the fix/AG-154_bedrock_gemini_function_calling branch 3 times, most recently from 9f6fdbe to 0142f6f Compare November 13, 2024 18:09
@tysoekong
Copy link
Contributor Author

@oowl @fffonion ready?

@tysoekong tysoekong force-pushed the fix/AG-154_bedrock_gemini_function_calling branch from 0142f6f to 7bbaaad Compare November 16, 2024 01:46
@tysoekong tysoekong changed the title fix(ai-proxy): (Bedrock)(Gemini)(AG-154) fixed tools-functions calls coming back empty fix(ai-proxy): (multiple)(AG-154) fixed tools-functions calls coming back empty Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oowl oowl oowl left review comments

@fffonion fffonion fffonion left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees

@tysoekong tysoekong

Labels
backport release/3.8.x cherry-pick kong-ee schedule this PR for cherry-picking to kong/kong-ee plugins/ai-proxy plugins/ai-request-transformer plugins/ai-response-transformer schema-change-noteworthy size/XL
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@tysoekong @fffonion @oowl @team-eng-enablement @team-gateway-bot @AntoineJac