-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(prometheus): add wasmx metrics #13681
Conversation
3973b56
to
75873f8
Compare
cf4e4c3
to
d241e68
Compare
9d62b9a
to
37604f7
Compare
37604f7
to
b60e5bb
Compare
81f0148
to
5d995c5
Compare
3f444c0
to
636717d
Compare
636717d
to
793ee47
Compare
793ee47
to
7745f0a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all the work you've put into this!
I left a couple inline comments about small things to address before merge, but it's looking good to me.
7745f0a
to
e5ef88d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for addressing the feedback and providing additional details, looks good to me
rebasing... |
e5ef88d
to
09e0704
Compare
Cherry-pick failed for Please cherry-pick the changes locally. git remote add upstream https://github.com/kong/kong-ee
git fetch upstream master
git worktree add -d .worktree/cherry-pick-13681-to-master-to-upstream upstream/master
cd .worktree/cherry-pick-13681-to-master-to-upstream
git checkout -b cherry-pick-13681-to-master-to-upstream
ancref=$(git merge-base dcf89f39e85bd91fb7a3798c5a36b5d6f384a264 09e0704dc4964f46cf5f00cb66cff5dc27b82f6f)
git cherry-pick -x $ancref..09e0704dc4964f46cf5f00cb66cff5dc27b82f6f |
Summary
Checklist
changelog/unreleased/kong
orskip-changelog
label added on PR if changelog is unnecessary. README.mdIssue reference
Fix #[issue number]