Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build): create debug symbols package #11504

Closed
wants to merge 2 commits into from

Conversation

locao
Copy link
Contributor

@locao locao commented Aug 31, 2023

Summary

To keep the size impact of adding Wasm to the Gateway images to a minimum, we are splitting the debug symbols out of ngx_wasm_module.so into an independent file (ngx_wasm_module.so.dbg) and packaging it in a new package, kong-debuginfo.

As the new package is called kong-debuginfo, libatc_router.so was also splitted into a new debug shared object, keeping the behavior consistent in all kong-owned shared objects.

Checklist

  • The Pull Request has tests
  • A changelog file has been added to CHANGELOG/unreleased/kong or adding skip-changelog label on PR if unnecessary. README.md (Please ping @vm-001 if you need help)
  • There is a user-facing docs PR against https://github.com/Kong/docs.konghq.com - PUT DOCS PR HERE

Full changelog

  • New build argument to split shared objects.
  • Build step to split kong shared objects.
  • New package containing only the debug shared objects.

Issue reference

KAG-1990

@locao locao force-pushed the feat/debug_symbols_package branch from d5c2e31 to 3cf112e Compare August 31, 2023 15:00
@github-actions github-actions bot added the chore Not part of the core functionality of kong, but still needed label Aug 31, 2023
@fffonion
Copy link
Contributor

fffonion commented Sep 8, 2023

I'm generally onboard to put all debug symbols in seperate package (see https://konghq.atlassian.net/browse/KAG-994), but I'm not sure how other people feel about it.
So it feels bit intermediate state to me that we are also splitting atc_router.so. My suggestion is to either only keep doing for wasm libraries, or do for all other libraries.
Let's also use well-known naming conversion for debug info packages, like kong.debugsyms.ddeb.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 6, 2023

This PR is marked as stale because it has been open for 14 days with no activity.

@github-actions github-actions bot added the stale label Oct 6, 2023
@locao
Copy link
Contributor Author

locao commented Nov 13, 2024

I am closing this PR for the time being. It seems we don't want to include this change any time soon.

@locao locao closed this Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build/bazel chore Not part of the core functionality of kong, but still needed size/L stale
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants