kgo: add args and provide current defaults via env #1058
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Provide
args
section KGO chart.This will help users to migrate from pre 1.2 versions which didn't have the ability to use the env vars (implemented in https://github.com/Kong/gateway-operator-archive/pull/1616).
The reason for this is that pre 1.2 had
ControlPlane
andGatewayConfiguration
inv1alpha1
and 1.2+ have those CRDs only defined inv1beta1
which makes it impossible to easily migrate using this chart which didn't provide users a way to disableGateway
andControlPlane
controllers to prevent errors like these:Using the
args
provided in this PR users will be able to disable the controllers that require manual upgrade path (ControlPlane
andGateway
), migrate to a newer KGO version, install new CRDs, and if they'd like enable those disabled controllers.