Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kgo: add args and provide current defaults via env #1058

Merged
merged 1 commit into from
Apr 18, 2024
Merged

Conversation

pmalek
Copy link
Member

@pmalek pmalek commented Apr 18, 2024

What this PR does / why we need it:

Provide args section KGO chart.

This will help users to migrate from pre 1.2 versions which didn't have the ability to use the env vars (implemented in https://github.com/Kong/gateway-operator-archive/pull/1616).

The reason for this is that pre 1.2 had ControlPlane and GatewayConfiguration in v1alpha1 and 1.2+ have those CRDs only defined in v1beta1 which makes it impossible to easily migrate using this chart which didn't provide users a way to disable Gateway and ControlPlane controllers to prevent errors like these:

manager {"level":"error","ts":"2024-04-18T12:33:54Z","msg":"failed to run manager","error":"no matches for kind \"ControlPlane\" in version \"gateway-operator.konghq.com/v1beta1\"","stacktrace":"main.main\n\t/workspace/main.go:17\nruntime.main\n\t/usr/local/go/src/runtime/proc.go:271"}
Stream closed EOF for kong-system/kgo-gateway-operator-controller-manager-7549bd865b-vvzkt (manager)

Using the args provided in this PR users will be able to disable the controllers that require manual upgrade path (ControlPlane and Gateway), migrate to a newer KGO version, install new CRDs, and if they'd like enable those disabled controllers.

@pmalek pmalek self-assigned this Apr 18, 2024
@pmalek pmalek marked this pull request as ready for review April 18, 2024 13:22
@pmalek pmalek requested a review from a team as a code owner April 18, 2024 13:22
@pmalek pmalek force-pushed the kgo-add-args branch 2 times, most recently from 2a4f6db to e2d5655 Compare April 18, 2024 14:27
@pmalek pmalek requested a review from czeslavo April 18, 2024 14:27
czeslavo
czeslavo previously approved these changes Apr 18, 2024
@pmalek pmalek merged commit 3604b7f into main Apr 18, 2024
30 checks passed
@pmalek pmalek deleted the kgo-add-args branch April 18, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants