Skip to content

Commit

Permalink
fix(certificate): correcting format and removing unnecessary config (#…
Browse files Browse the repository at this point in the history
…791)

* fix(certificate): correcting format and removing unnecessary config

Fix correct timestamp format
Remove isCA as it is not necessary to configure it as false

* Update charts/kong/CHANGELOG.md

---------

Co-authored-by: Patryk Małek <[email protected]>
  • Loading branch information
philipsabri and pmalek authored May 4, 2023
1 parent dd8bae5 commit c2da784
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 5 deletions.
9 changes: 8 additions & 1 deletion charts/kong/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
# Changelog

## 2.20.1

### Fixed

* Fix correct timestamp format and remove `isCA` in certificates
[#791](https://github.com/Kong/charts/pull/791)

## 2.20.0

### Improvements
Expand Down Expand Up @@ -52,7 +59,7 @@
[#747](https://github.com/Kong/charts/pull/747)
* Added experimental support for the ingress controller's Konnect sync feature via `ingressController.konnect.*` values.
This feature is only available when deploying chart with Kong Ingress Controller in version 2.9 or higher and
requires `ingressController.gatewayDiscovery.enabled` set to `true`.
requires `ingressController.gatewayDiscovery.enabled` set to `true`.
[#746](https://github.com/Kong/charts/pull/746)
* Added support for annotations on the admission webhook ValidatingWebhookConfiguration.
[#760](https://github.com/Kong/charts/pull/760)
Expand Down
2 changes: 1 addition & 1 deletion charts/kong/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ maintainers:
name: kong
sources:
- https://github.com/Kong/charts/tree/main/charts/kong
version: 2.20.0
version: 2.20.1
appVersion: "3.2"
dependencies:
- name: postgresql
Expand Down
5 changes: 2 additions & 3 deletions charts/kong/templates/certificate.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,8 @@ spec:
{{- range (append .dnsNames .commonName) }}
- {{ . | quote }}
{{- end }}
renewBefore: 360h
duration: 2160h
isCA: false
renewBefore: 360h0m0s
duration: 2160h0m0s
{{ if .subject -}}
subject:
{{- toYaml .subject | nindent 4 }}
Expand Down

0 comments on commit c2da784

Please sign in to comment.