Skip to content

Commit

Permalink
kong: fix typos for .Release.Namespace
Browse files Browse the repository at this point in the history
From #18 
Close #9 
Fix #11 

Co-authored-by: Łukasz Tomaszkiewicz <[email protected]>
  • Loading branch information
hbagdi and tomaszkiewicz authored Jan 23, 2020
1 parent 0a73684 commit 3237cd5
Show file tree
Hide file tree
Showing 4 changed files with 18 additions and 13 deletions.
2 changes: 1 addition & 1 deletion charts/kong/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,5 @@ maintainers:
email: [email protected]
name: kong
sources:
version: 1.0.2
version: 1.0.3
appVersion: 1.4
25 changes: 15 additions & 10 deletions charts/kong/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -143,19 +143,19 @@ for more details.

There are three different packages of Kong that are available:

- **Kong Gateway**
- **Kong Gateway**\
This is the [Open-Source](https://github.com/kong/kong) offering. It is a
full-blown API Gateway and Ingress solution with a wide-array of functionality.
When Kong Gateway is combined with the Ingress based configuration method,
you get Kong for Kubernetes. This is the default deployment for this Helm
Chart.
- **Kong Enterprise K8S**
- **Kong Enterprise K8S**\
This package builds up on top of the Open-Source Gateway and bundles in all
the Enterprise-only plugins as well.
When Kong Enterprise K8S is combined with the Ingress based
configuration method, you get Kong for Kubernetes Enterprise.
This package also comes with 24x7 support from Kong Inc.
- **Kong Enterprise**
- **Kong Enterprise**\
This is the full-blown Enterprise package which packs with itself all the
Enterprise functionality like Manager, Portal, Vitals, etc.
This package can't be run in DB-less mode.
Expand All @@ -167,7 +167,7 @@ the [Kong Enterprise Parameters](#kong-enterprise-parameters) section.
### Configuration method

Kong can be configured via two methods:
- **Ingress and CRDs**
- **Ingress and CRDs**\
The configuration for Kong is done via `kubectl` and Kubernetes-native APIs.
This is also known as Kong Ingress Controller or Kong for Kubernetes and is
the default deployment pattern for this Helm Chart. The configuration
Expand All @@ -178,7 +178,7 @@ Kong can be configured via two methods:
on Kong Ingress Controller.
To configure and fine-tune the controller, please read the
[Ingress Controller Parameters](#ingress-controller-parameters) section.
- **Admin API**
- **Admin API**\
This is the traditional method of running and configuring Kong.
By default, the Admin API of Kong is not exposed as a Service. This
can be controlled via `admin.enabled` and `env.admin_listen` parameters.
Expand Down Expand Up @@ -260,7 +260,7 @@ section of `values.yaml` file:
| admissionWebhook.failurePolicy | How unrecognized errors from the admission endpoint are handled (Ignore or Fail) | Fail |
| admissionWebhook.port | The port the ingress controller will listen on for admission webhooks | 8080 |

For a complete list of all configuration values you can set in the
For a complete list of all configuration values you can set in the
`env` section, please read the Kong Ingress Controller's
[configuration document](https://github.com/Kong/kubernetes-ingress-controller/blob/master/docs/references/cli-arguments.md).

Expand Down Expand Up @@ -464,9 +464,14 @@ value is your SMTP password.
## Changelog
### 1.0.3
- Helm 3 support: CRDs are declared in crds directory. Backward compatible support for helm 2.
### 1.0.2
Helm 3 support: CRDs are declared in crds directory. Backward compatible support for helm 2.
- Fix invalid namespace for pre-migrations and Role.
- Fix whitespaces formatting in README.
### 1.0.1
Expand Down Expand Up @@ -531,9 +536,9 @@ deprecated.
- When upgrading from <0.35.0, in-place chart upgrades will fail.
It is necessary to delete the helm release with `helm del --purge $RELEASE` and redeploy from scratch.
Note that this will cause downtime for the kong proxy.
Note that this will cause downtime for the kong proxy.
#### Improvements
#### Improvements
- Fixed Deployment's label selector that prevented in-place chart upgrades.
Expand Down Expand Up @@ -737,7 +742,7 @@ Following changes have no end user visible effects:
#### Breaking changes
- The configuration format for ingresses in values.yaml has changed.
- The configuration format for ingresses in values.yaml has changed.
Previously, all ingresses accepted an array of hostnames, and would create
ingress rules for each. Ingress configuration for services other than the proxy
now accepts a single hostname, which allows simpler TLS configuration and
Expand Down
2 changes: 1 addition & 1 deletion charts/kong/templates/controller-rbac-resources.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ apiVersion: rbac.authorization.k8s.io/v1beta1
kind: Role
metadata:
name: {{ template "kong.fullname" . }}
namespace: {{ .Release.namespace }}
namespace: {{ .Release.Namespace }}
labels:
{{- include "kong.metaLabels" . | nindent 4 }}
rules:
Expand Down
2 changes: 1 addition & 1 deletion charts/kong/templates/migrations-pre-upgrade.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ apiVersion: v1
kind: ServiceAccount
metadata:
name: {{ template "kong.serviceAccountName" . }}
namespace: {{ .Release.namespace }}
namespace: {{ .Release.Namespace }}
annotations:
"helm.sh/hook": pre-upgrade
"helm.sh/hook-delete-policy": before-hook-creation,hook-succeeded
Expand Down

0 comments on commit 3237cd5

Please sign in to comment.