use p2pkh vout instead of p2pk for change when -pubkey specified #638
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this will help Iguana identify the change UTXOs and use them for splitting.
smk762
approved these changes
Oct 17, 2024
Yes, except the cases when all remaining balance it's generated coins. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As is well known, Iguana uses P2PKH UTXOs for splitting and converts them into 10,000 zat P2PK UTXOs for notarizing. However, it cannot split from P2PK UTXOs. When you run
komododwith the-pubkeyargument, specifying your notary pubkey, any transaction created inside the daemon will send change (if any) as a P2PK output, i.e., to the<pubkey> OP_CHECKSIGscript. As a result, Iguana cannot split such UTXOs. This change modifies that behavior, making the change a standard P2PKH output if a pubkey is specified.