Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GLEEC_OLD: exception to fix following the notarizations #637

Merged
merged 2 commits into from
Oct 17, 2024

Conversation

DeckerSU
Copy link

This update should fix the notarization issue with the old GLEEC chain. After applying the fix, the output of the getinfo RPC call should look something like this:

komodo-cli -ac_name=GLEEC -datadir=/home/builder/.komodo/GLEEC_OLD getinfo | jq .
{
  "version": 90000,
  "protocolversion": 170013,
  "KMDversion": "0.9.0",
  "synced": true,
  "notarized": 974444,
  "prevMoMheight": 974444,
  "notarizedhash": "0958f1dd625d89d5749b698cbf7e57eb294dd1916d828d60fbf9de9dfd9053e4",
  "notarizedtxid": "7fdc3a5452baef619452408cc31fac86de468755380914d7f172dc78b7702ac8",
  "notarizedtxid_height": "mempool",
  "KMDnotarized_height": 0,
  "notarized_confirms": 0,
  "walletversion": 60000,
  "balance": 0,
  "blocks": 974458,
  "longestchain": 974458,
  "tiptime": 1728914950,
  "difficulty": 1,
  "keypoololdest": 1728668685,
  "keypoolsize": 101,
  "paytxfee": 0,
  "sapling": 61,
  "timeoffset": 0,
  "connections": 16,
  "proxy": "",
  "testnet": false,
  "relayfee": 1e-06,
  "errors": "",
  "name": "GLEEC_OLD",
  "p2pport": 23225,
  "rpcport": 23226,
  "magic": 1824725725,
  "premine": 210000000,
  "staked": 100
}

The fix changes the chain name (ticker) "at runtime," allowing us to keep the existing chain parameters and magic. Normally, we wouldn’t do something like this, but for the old GLEEC chain, we will make an exception. Additionally, the user should create a symlink for the .conf file like this:

ln -s -f $HOME/.komodo/GLEEC_OLD/GLEEC.conf $HOME/.komodo/GLEEC_OLD/GLEEC_OLD.conf

The daemon should be launched with -datadir=$HOME/.komodo/GLEEC_OLD, and the data directory should contain GLEEC.conf along with a symlink to it named GLEEC_OLD.conf.

This configuration assumes that we have the `~/.komodo/GLEEC_OLD`
directory for the old GLEEC chain. The daemon should be launched
with `-datadir=$HOME/.komodo/GLEEC_OLD`, and the data directory
should contain `GLEEC.conf` along with a symlink to it
named `GLEEC_OLD.conf`.
@DeckerSU DeckerSU requested a review from smk762 October 14, 2024 14:17
@smk762
Copy link

smk762 commented Oct 14, 2024

Will this change the ticker in decoded op_return also?

@DeckerSU
Copy link
Author

Will this change the ticker in decoded op_return also?

We already did this in iguana.

src/komodo_utils.cpp Outdated Show resolved Hide resolved
@smk762 smk762 self-requested a review October 17, 2024 10:44
@DeckerSU DeckerSU merged commit 820fe50 into dev Oct 17, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants