fix old and new gleec checkpoints #629
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
download-artifact@v4+ is not currently supported on GHES yet.
gcharang
approved these changes
Sep 25, 2024
smk762
approved these changes
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an error with relaying and propagating transactions on the
new GLEECchain. Since theold GLEECchain was protected with checkpoints and the new chain shares the same ticker, the node assumed that Initial Block Download (IBD) hadn’t finished and therefore didn’t accepttxp2p messages. The system wasn’t designed to handle two different chains with the same name. This PR resolves the issue. In the future, I recommend deprecating the old GLEEC chain and avoiding such conflicts to prevent similar issues.